Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] sync validator translations#30946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromxabbuh:pr-27738-translations
Apr 7, 2019

Conversation

@xabbuh
Copy link
Member

@xabbuhxabbuh commentedApr 7, 2019•
edited
Loading

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

#FOSSHackathons #EUFOSSA

@xabbuh
Copy link
MemberAuthor

@hhamon
Copy link
Contributor

hhamon commentedApr 7, 2019•
edited
Loading

French version:

Ce mot de passe a été révélé par une faille de sécurité et ne devrait plus être utilisé. Veuillez utiliser un autre mot de passe.

@lyrixx
Copy link
Member

Why did you target Symfony 3.4? The valdator has been introduced in 4.3

hhamon reacted with thumbs up emoji

@xabbuh
Copy link
MemberAuthor

@lyrixx To ease the maintainability of the translations we always add them on the lowest maintained branch. But in fact we already messed up ids between branches. I am trying to clean them up.

lyrixx reacted with thumbs up emoji

@xabbuhxabbuhforce-pushed thepr-27738-translations branch 4 times, most recently from1a30a0f tod2f3a28CompareApril 7, 2019 08:22
@xabbuhxabbuh marked this pull request as ready for reviewApril 7, 2019 08:26
@xabbuhxabbuh changed the title[Validator] translate the not compromised constraint message[Validator] sync validator translationsApr 7, 2019
@xabbuhxabbuhforce-pushed thepr-27738-translations branch fromd2f3a28 to83f675dCompareApril 7, 2019 11:53
@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit83f675d intosymfony:3.4Apr 7, 2019
fabpot added a commit that referenced this pull requestApr 7, 2019
This PR was merged into the 3.4 branch.Discussion----------[Validator] sync validator translations| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |#FOSSHackathons #EUFOSSACommits-------83f675d sync validator translations
@xabbuhxabbuh deleted the pr-27738-translations branchApril 7, 2019 16:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@derrabusderrabusderrabus left review comments

@OskarStarkOskarStarkOskarStark requested changes

+2 more reviewers

@jschaedljschaedljschaedl approved these changes

@dbrumanndbrumanndbrumann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

10 participants

@xabbuh@hhamon@lyrixx@fabpot@nicolas-grekas@OskarStark@derrabus@jschaedl@dbrumann@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp