NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[3.4] [Validator] Add missing french validators translations#30945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:3.4fromhhamon:validator-add-missing-french-translations

Apr 7, 2019

Merged

[3.4] [Validator] Add missing french validators translations#30945

fabpot merged 1 commit intosymfony:3.4fromhhamon:validator-add-missing-french-translations

Apr 7, 2019

Conversation

Copy link

Contributor

hhamon commentedApr 7, 2019

Q	A
Branch?	3.4
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	~
License	MIT
Doc PR	~

carsonbot added Status: Needs Review Validator labels

Apr 7, 2019

xabbuh added this to the3.4 milestone

Apr 7, 2019

xabbuh added the ⭐️ EUFOSSA Hackathon label

Apr 7, 2019

Copy link

Member

javiereguiluz commentedApr 7, 2019

Very nice! We'd also include another new translation. See#30946.

Copy link

ContributorAuthor

hhamon commentedApr 7, 2019

Thanks Javier!

I've put the french translation for the compromised password constraint in@xabbuh's PR so that he can update the file accordingly :)

lyrixx approved these changes

Apr 7, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Apr 7, 2019

fabpot reviewed

Apr 7, 2019

View reviewed changes

src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf OutdatedShow resolvedHide resolved

xabbuh previously requested changes

Apr 7, 2019

View reviewed changes

src/Symfony/Component/Validator/Resources/translations/validators.fr.xlfShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Reviewed labels

Apr 7, 2019

xabbuh mentioned this pull request

Apr 7, 2019

[4.3] [Validator] add missing french validator translations.#30949

Closed

hhamon force-pushed thevalidator-add-missing-french-translations branch 3 times, most recently from6f980d4 to5cfd0d0Compare

April 7, 2019 08:25

hhamon changed the title~~[3.4] [Validator] Add missing french validators translation~~[3.4] [Validator] Add missing french validators translations

Apr 7, 2019

greg0ire suggested changes

Apr 7, 2019

View reviewed changes

src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf OutdatedShow resolvedHide resolved

xabbuh dismissed theirstale review

April 7, 2019 08:27

I don't know anything abot French

hhamon force-pushed thevalidator-add-missing-french-translations branch 4 times, most recently from8d35900 to0883342Compare

April 7, 2019 08:32

[3.4] [Validator] Add missing french validation translations.

331b601

hhamon force-pushed thevalidator-add-missing-french-translations branch from0883342 to331b601Compare

April 7, 2019 08:33

Copy link

ContributorAuthor

hhamon commentedApr 7, 2019

I think it's good to go!

fabpot approved these changes

Apr 7, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Apr 7, 2019

Copy link

Member

fabpot commentedApr 7, 2019

Thank you@hhamon.

fabpot merged commit331b601 intosymfony:3.4

Apr 7, 2019

fabpot added a commit that referenced this pull request

Apr 7, 2019

minor#30945[3.4] [Validator] Add missing french validators translat…

6ea4d79

…ions (hhamon)This PR was merged into the 3.4 branch.Discussion----------[3.4] [Validator] Add missing french validators translations| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | ~| License       | MIT| Doc PR        | ~Commits-------331b601 [3.4] [Validator] Add missing french validation translations.