Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Improve invalid messages for form types#30931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@webmozart
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#27142,#5946
LicenseMIT
Doc PRTODO

This merge request is a continuation of#27142.

Changes done here:

  • rebased on master
  • made the error messages friendlier

sstok reacted with hooray emoji
Copy link
Contributor

@HeahDudeHeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some CS changes looks wrong. Otherwise looks good, thanks!

Copy link
Contributor

@HeahDudeHeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Many thanks@hiddewie and@webmozart for finishing it!

@webmozart
Copy link
ContributorAuthor

The build fails, but I'm unable to reproduce this locally :-\ Can anyone help me there?

@fabpot
Copy link
Member

@xabbuh Do you a plan to finish this PR?

@fabpot
Copy link
Member

@xabbuh Friendly ping :)

@xabbuhxabbuhforce-pushed thecustomized-invalid-messages branch 7 times, most recently fromd693fe8 to200008fCompareJuly 8, 2020 16:34
@xabbuhxabbuhforce-pushed thecustomized-invalid-messages branch from200008f tod2f0e4fCompareJuly 9, 2020 08:29
@ogizanagi
Copy link
Contributor

Thank you@xabbuh for taking care of this 👍

@xabbuhxabbuhforce-pushed thecustomized-invalid-messages branch 2 times, most recently frombfed611 to0137ee1CompareJuly 10, 2020 08:37
@xabbuhxabbuhforce-pushed thecustomized-invalid-messages branch from0137ee1 to8728927CompareJuly 10, 2020 09:36
@xabbuh
Copy link
Member

Thank you Bernhard.

sstok reacted with rocket emoji

@xabbuh
Copy link
Member

And thank you@hiddewie for doing the initial work!

hiddewie, ogizanagi, and sstok reacted with thumbs up emoji

@xabbuhxabbuh merged commitdfc3267 intosymfony:masterJul 10, 2020
@nicolas-grekasnicolas-grekas modified the milestones:next,5.2Oct 5, 2020
@fabpotfabpot mentioned this pull requestOct 5, 2020
fabpot added a commit that referenced this pull requestOct 20, 2020
This PR was squashed before being merged into the 5.x branch.Discussion----------[Form] Add missing invalid_message translations| Q             | A| ------------- | ---| Branch?       | 5.x| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Some invalid messages were missed in#30931 (probably because of the old age of that PR). This PR adds all missing translation keys and a missing invalid message for the new WeekType.I've also added the dutch translations (might be up for improvement, but it's a start). We should probably initiate another community initiative to translate these new messages (only a couple languages include the new invalid messages yet).Commits-------86c78b6 Added dutch translations for new invalid messages301f0aa Added missing invalid messages
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@xabbuhxabbuhxabbuh approved these changes

@fabpotfabpotfabpot approved these changes

+4 more reviewers

@hhamonhhamonhhamon left review comments

@ogizanagiogizanagiogizanagi approved these changes

@sstoksstoksstok approved these changes

@HeahDudeHeahDudeHeahDude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

12 participants

@webmozart@fabpot@ogizanagi@xabbuh@hhamon@sstok@OskarStark@HeahDude@nicolas-grekas@lsmith77@carsonbot@hiddewie
[8]ページ先頭
©2009-2025 Movatter.jp