Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Fix table trailing backslash#30911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.2frommaidmaid:table-backslash
Apr 6, 2019

Conversation

@maidmaid
Copy link
Contributor

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30725
LicenseMIT
Doc PR/
(newTable($output))    ->setColumnMaxWidth(0,5)    ->setRows([['1234\6']])    ->render();;

before:

+-------+| 1234<fg=default;bg=default> || 6     |+-------+

after:

+-------+| 1234\ || 6     |+-------+

#EUFOSSA

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(can you confirm the issue doesn't exist on 3.4?)

@nicolas-grekas
Copy link
Member

Can you please have a look at#30852?

maidmaid reacted with eyes emoji

@maidmaid
Copy link
ContributorAuthor

4.2 becausesetColumnMaxWidth() was introduced for that version.
cfhttps://symfony.com/blog/new-in-symfony-4-2-console-tables-improvements#setting-the-max-width-of-columns

@maidmaid
Copy link
ContributorAuthor

@nicolas-grekas About#30852, it's 2 different problems IMO : this PR relates the trailing\, whereas the other relates the too long contents.

@fabpot
Copy link
Member

Thank you@maidmaid.

@fabpotfabpot merged commit48f020f intosymfony:4.2Apr 6, 2019
fabpot added a commit that referenced this pull requestApr 6, 2019
This PR was merged into the 4.2 branch.Discussion----------[Console] Fix table trailing backslash| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30725| License       | MIT| Doc PR        | /```php(new Table($output))    ->setColumnMaxWidth(0, 5)    ->setRows([['1234\6']])    ->render();;```before:```+-------+| 1234<fg=default;bg=default> || 6     |+-------+```after:```+-------+| 1234\ || 6     |+-------+```#EUFOSSACommits-------48f020f Fix table trailing backslash
@maidmaidmaidmaid deleted the table-backslash branchApril 6, 2019 16:37
@fabpotfabpot mentioned this pull requestApr 16, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@maidmaid@nicolas-grekas@fabpot@chalasr@maxhelias@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp