Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] provide new ObjectPropertyListExtractorInterface#30904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromdmaicher:serializer-prop-extractor
Apr 6, 2019

Conversation

@dmaicher
Copy link
Contributor

@dmaicherdmaicher commentedApr 6, 2019
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsrelated to#30818
LicenseMIT
Doc PR-

EUFOSSA Hackathon

As discussed with@joelwurtz this adds a newObjectPropertyListExtractorInterface and a default implementation.

See#30818

A new interface will be provided ObjectPropertyListExtractorInterface (name can change), that allow getting attributes based on an object. A default implementation will be provided that use the PropertyListExtractorInterface and a class resolver, as the latter one only rely on class name, it may be important to have this distinction (this will allow features that rely on a specific value of the object to get the current property list, like exclusion policy)

@dmaicherdmaicherforce-pushed theserializer-prop-extractor branch from76c748c toa146024CompareApril 6, 2019 15:39
Copy link
Contributor

@joelwurtzjoelwurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks looks nice

dmaicher reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@dmaicher.

@fabpotfabpot merged commit997270f intosymfony:masterApr 6, 2019
fabpot added a commit that referenced this pull requestApr 6, 2019
…terface (dmaicher)This PR was merged into the 4.3-dev branch.Discussion----------[Serializer] provide new ObjectPropertyListExtractorInterface| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | related to#30818| License       | MIT| Doc PR        | -EUFOSSA HackathonAs discussed with@joelwurtz this adds a new `ObjectPropertyListExtractorInterface` and a default implementation.See#30818>  A new interface will be provided ObjectPropertyListExtractorInterface (name can change), that allow getting attributes based on an object. A default implementation will be provided that use the PropertyListExtractorInterface and a class resolver, as the latter one only rely on class name, it may be important to have this distinction (this will allow features that rely on a specific value of the object to get the current property list, like exclusion policy)Commits-------997270f [Serializer] provide new ObjectPropertyListExtractorInterface
@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 6, 2019
fabpot added a commit that referenced this pull requestApr 6, 2019
…tExtractorInterface (dmaicher)This PR was merged into the 4.3-dev branch.Discussion----------[Serializer] add return type hints for ObjectPropertyListExtractorInterface| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Fixed tickets | -| License       | MIT| Doc PR        | -@nicolas-grekas as just discussed here the type-hint + phpdoc cleanup as follow-up for#30904 😉cc@joelwurtzCommits-------7628972 [Serializer] add return type hints for ObjectPropertyListExtractorInterface
nicolas-grekas added a commit that referenced this pull requestApr 7, 2019
…lwurtz)This PR was merged into the 4.3-dev branch.Discussion----------[Serializer] Experimental for ObjectListExtractor| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30904| License       | MIT| Doc PR        | -Related to#30818I want to mark this class as `@expiremental` until we have the full refactoring done of the Serializer, also this would allow change needed if some behavior was not correctly taken into care in 4.3Mark also `final` for the default implementation as we don't want that to be extendable and user should use composition over inheritance.Commits-------b0cdf45 Set object list extractor as expiremental, and use final for default implementation
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@joelwurtzjoelwurtzjoelwurtz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@dmaicher@fabpot@joelwurtz@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp