Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] provide new ObjectPropertyListExtractorInterface#30904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
dmaicher commentedApr 6, 2019
src/Symfony/Component/Serializer/Extractor/ObjectPropertyListExtractor.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Serializer/Tests/Extractor/ObjectPropertyListExtractorTest.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
76c748c toa146024Comparea146024 to997270fCompare16 tasks
joelwurtz approved these changesApr 6, 2019
Contributor
joelwurtz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks looks nice
fabpot approved these changesApr 6, 2019
Member
fabpot commentedApr 6, 2019
Thank you@dmaicher. |
fabpot added a commit that referenced this pull requestApr 6, 2019
…terface (dmaicher)This PR was merged into the 4.3-dev branch.Discussion----------[Serializer] provide new ObjectPropertyListExtractorInterface| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | related to#30818| License | MIT| Doc PR | -EUFOSSA HackathonAs discussed with@joelwurtz this adds a new `ObjectPropertyListExtractorInterface` and a default implementation.See#30818> A new interface will be provided ObjectPropertyListExtractorInterface (name can change), that allow getting attributes based on an object. A default implementation will be provided that use the PropertyListExtractorInterface and a class resolver, as the latter one only rely on class name, it may be important to have this distinction (this will allow features that rely on a specific value of the object to get the current property list, like exclusion policy)Commits-------997270f [Serializer] provide new ObjectPropertyListExtractorInterface
fabpot added a commit that referenced this pull requestApr 6, 2019
…tExtractorInterface (dmaicher)This PR was merged into the 4.3-dev branch.Discussion----------[Serializer] add return type hints for ObjectPropertyListExtractorInterface| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Fixed tickets | -| License | MIT| Doc PR | -@nicolas-grekas as just discussed here the type-hint + phpdoc cleanup as follow-up for#30904 😉cc@joelwurtzCommits-------7628972 [Serializer] add return type hints for ObjectPropertyListExtractorInterface
nicolas-grekas added a commit that referenced this pull requestApr 7, 2019
…lwurtz)This PR was merged into the 4.3-dev branch.Discussion----------[Serializer] Experimental for ObjectListExtractor| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#30904| License | MIT| Doc PR | -Related to#30818I want to mark this class as `@expiremental` until we have the full refactoring done of the Serializer, also this would allow change needed if some behavior was not correctly taken into care in 4.3Mark also `final` for the default implementation as we don't want that to be extendable and user should use composition over inheritance.Commits-------b0cdf45 Set object list extractor as expiremental, and use final for default implementation
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
EUFOSSA Hackathon
As discussed with@joelwurtz this adds a new
ObjectPropertyListExtractorInterfaceand a default implementation.See#30818