NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Validator] add new`Timezone` validation constraint#30900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromhhamon:tz_validator

Apr 6, 2019

Merged

[Validator] add new`Timezone` validation constraint#30900

fabpot merged 1 commit intosymfony:masterfromhhamon:tz_validator

Apr 6, 2019

Conversation

Copy link

Contributor

hhamon commentedApr 6, 2019•
edited
Loading

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
License	MIT
Doc PR	symfony/symfony-docs#11317

Rework of#22262.

carsonbot added Status: Needs Review Feature labels

Apr 6, 2019

hhamon force-pushed thetz_validator branch from6783f94 toce70747Compare

April 6, 2019 14:03

hhamon mentioned this pull request

Apr 6, 2019

[Validator] AddTimezoneValidator#22262

Closed

2 tasks

hhamon force-pushed thetz_validator branch 3 times, most recently from8e03af4 to6b6c8d0Compare

April 6, 2019 14:15

nicolas-grekas added this to thenext milestone

Apr 6, 2019

nicolas-grekas reviewed

Apr 6, 2019

View reviewed changes

src/Symfony/Component/Validator/Constraints/TimezoneValidator.php OutdatedShow resolvedHide resolved

nicolas-grekas added the ⭐️ EUFOSSA Hackathon label

Apr 6, 2019

hhamon force-pushed thetz_validator branch from6b6c8d0 tof87bf3bCompare

April 6, 2019 14:25

Copy link

ContributorAuthor

hhamon commentedApr 6, 2019

Also documentation PR is on its way as well ;)

jewome62 reviewed

Apr 6, 2019

View reviewed changes

src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf OutdatedShow resolvedHide resolved

hhamon force-pushed thetz_validator branch fromf87bf3b to6016ca8Compare

April 6, 2019 14:36

hhamon changed the title~~Add newTimezoneValidator~~[Validator] add newTimezone validation constraint

Apr 6, 2019

hhamon mentioned this pull request

Apr 6, 2019

[Validator] add documentation for the newTimezone constraint.symfony/symfony-docs#11317

Merged

OskarStark reviewed

Apr 6, 2019

View reviewed changes

src/Symfony/Component/Validator/Resources/translations/validators.en.xlfShow resolvedHide resolved

hhamon force-pushed thetz_validator branch from6016ca8 to9f7ed5aCompare

April 6, 2019 14:42

xabbuh approved these changes

Apr 6, 2019

View reviewed changes

Copy link

Member

xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

with a minor change request

src/Symfony/Component/Validator/Constraints/TimezoneValidator.php OutdatedShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Apr 6, 2019

hhamon force-pushed thetz_validator branch 2 times, most recently fromf13c04b toe619668Compare

April 6, 2019 16:25

fabpot requested changes

Apr 6, 2019

View reviewed changes

src/Symfony/Component/Validator/Constraints/Timezone.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Reviewed labels

Apr 6, 2019

hhamon force-pushed thetz_validator branch frome619668 to1675760Compare

April 6, 2019 18:42

fabpot requested changes

Apr 6, 2019

View reviewed changes

src/Symfony/Component/Validator/Constraints/TimezoneValidator.php OutdatedShow resolvedHide resolved

[Validator] add newTimezone validation constraint.

536e53f

hhamon force-pushed thetz_validator branch from1675760 to536e53fCompare

April 6, 2019 18:45

fabpot approved these changes

Apr 6, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Apr 6, 2019

Copy link

Member

fabpot commentedApr 6, 2019

Thank you@hhamon.

fabpot merged commit536e53f intosymfony:master

Apr 6, 2019

fabpot added a commit that referenced this pull request

Apr 6, 2019

feature#30900[Validator] add newTimezonevalidation constraint (…

c73fd10

…phansys)This PR was merged into the 4.3-dev branch.Discussion----------[Validator] add new `Timezone` validation constraint| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MIT| Doc PR        |symfony/symfony-docs#11317Rework of#22262.Commits-------536e53f [Validator] add new `Timezone` validation constraint.

hhamon deleted the tz_validator branch

April 6, 2019 18:53

xabbuh mentioned this pull request

Apr 7, 2019

[3.4] [Validator] Add missing french validators translations#30945

Merged

wouterj added a commit to symfony/symfony-docs that referenced this pull request

Apr 7, 2019

feature#11317[Validator] add documentation for the newTimezonec…

d479fc2

…onstraint. (hhamon, javiereguiluz)This PR was merged into the master branch.Discussion----------[Validator] add documentation for the new `Timezone` constraint.This is the documentation related to PRsymfony/symfony#30900Commits-------8e33d47 Fixes classification5ec9159 Fix optionec7bd40 Revert country_code to countryCode9cbeb75 Fixes options list tablec5681bf Add more explanationsb37bc78 Minor fixesd564218 Minor fixesac6282f Listed the geographical zones defined by PHP135c5ff Minor fixesb0b1498 [Validator] add documentation for the new `Timezone` constraint.