Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 password#30898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromtgalopin:pwned-convert-encoding
Apr 6, 2019

Conversation

@tgalopin
Copy link
Contributor

@tgalopintgalopin commentedApr 6, 2019•
edited
Loading

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30870
LicenseMIT
Doc PR-

Live from #eu-fossa

Fix#30870

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A test case would be nice

dbrumann, jewome62, and derrabus reacted with thumbs up emoji
Copy link
Contributor

@ostroluckyostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think it makes too much sense to make this configurable. People who don't use UTF-8 should change internal_encoding php.ini setting

Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a test case.

@stof
Copy link
Member

stof commentedApr 6, 2019

FrameworkBundle should define a service for that constraint validator, passing%kernel.charset% for this argument. Otherwise, customizing this charset will be a pain in a fullstack project.

@tgalopin
Copy link
ContributorAuthor

@stof that's the aim, but it can be the subject of another PR IMO.

@tgalopin
Copy link
ContributorAuthor

Updated

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice one 🎉

@tgalopintgalopin changed the title[Validator] Convert encoding to UTF-8 when needed in NotPwnedValidator[Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 passwordApr 6, 2019
@tgalopintgalopin changed the title[Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 password[WIP][Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 passwordApr 6, 2019
@tgalopintgalopinforce-pushed thepwned-convert-encoding branch from239810d tobc0ba26CompareApril 6, 2019 16:33
@tgalopin
Copy link
ContributorAuthor

Based on#30889, otherwise ready to review.

@fabpot
Copy link
Member

@tgalopin Can you rebase?

@tgalopintgalopinforce-pushed thepwned-convert-encoding branch frombc0ba26 to4f74a33CompareApril 6, 2019 16:43
@tgalopintgalopin changed the title[WIP][Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 password[Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 passwordApr 6, 2019
@tgalopin
Copy link
ContributorAuthor

Updated

@tgalopintgalopinforce-pushed thepwned-convert-encoding branch from4f74a33 toc5cd75dCompareApril 6, 2019 17:09
@tgalopin
Copy link
ContributorAuthor

Updated

@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 6, 2019
@fabpotfabpotforce-pushed thepwned-convert-encoding branch fromc5cd75d to8ac712bCompareApril 6, 2019 17:56
@fabpot
Copy link
Member

Thank you@tgalopin.

@fabpotfabpot merged commit8ac712b intosymfony:masterApr 6, 2019
fabpot added a commit that referenced this pull requestApr 6, 2019
…ndle and handle non UTF-8 password (tgalopin)This PR was squashed before being merged into the 4.3-dev branch (closes#30898).Discussion----------[Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 password| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30870| License       | MIT| Doc PR        | -Live from #eu-fossaFix#30870Commits-------8ac712b [Validator] Wire NotCompromisedPassword in FrameworkBundle and handle non UTF-8 password
@tgalopintgalopin deleted the pwned-convert-encoding branchApril 6, 2019 18:54
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus requested changes

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglas

+4 more reviewers

@pborrelipborrelipborreli left review comments

@ostroluckyostroluckyostrolucky requested changes

@dbrumanndbrumanndbrumann approved these changes

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

NotPwnedValidator should convert passwords to UTF-8

12 participants

@tgalopin@stof@fabpot@pborreli@nicolas-grekas@ostrolucky@OskarStark@derrabus@dbrumann@maxhelias@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp