Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DIC] Add arequire env var processor#30897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@mpdude
Copy link
Contributor

@mpdudempdude commentedApr 6, 2019•
edited by chalasr
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PRsymfony/symfony-docs#11313

This adds a newrequire processor that willrequire() the PHP file given as input value and return the valuereturned from that file. Leverages opcaching (yay!).

#EUFOSSA

maxhelias and janopae reacted with heart emoji
@mpdude
Copy link
ContributorAuthor

Before I forget: Can I (or who can) add the FOSSHackathon label?

@mpdude
Copy link
ContributorAuthor

I guess tests are failing due to some other issue...?

@stof
Copy link
Member

stof commentedApr 6, 2019

@mpdude you should add the hashtags in the PR description (allowing to find all these issues and PR through the github search, even on multiple repos)

@stof
Copy link
Member

stof commentedApr 6, 2019

this requires either a doc PR or at least a doc issue.

@mpdude
Copy link
ContributorAuthor

Doc PR added.

@mpdude
Copy link
ContributorAuthor

you should add the hashtags in the PR description (allowing to find all these issues and PR through the github search, even on multiple repos)

@stof Not sure I understand how to do this

@xabbuhxabbuh added this to thenext milestoneApr 6, 2019
@mpdude
Copy link
ContributorAuthor

Regarding the failed tests, every test run fails due to different reasons. In all cases, I don't see how that would be related to this PR.

This allows to process .php files, returning the value returnedfrom that file. Leverages the opcache.
@mpdudempdudeforce-pushed therequire_env_processor branch from60ad78a to03da3a2CompareApril 7, 2019 08:30
@mpdude
Copy link
ContributorAuthor

Rebased on master to give Travis/CI tests another try.

@nicolas-grekas
Copy link
Member

Thank you@mpdude.

@nicolas-grekasnicolas-grekas merged commit03da3a2 intosymfony:masterApr 7, 2019
nicolas-grekas added a commit that referenced this pull requestApr 7, 2019
This PR was merged into the 4.3-dev branch.Discussion----------[DIC] Add a `require` env var processor| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |symfony/symfony-docs#11313This adds a new `require` processor that will `require()` the PHP file given as input value and return the value `return`ed from that file. Leverages opcaching (yay!).#EUFOSSACommits-------03da3a2 Add a `require` env var processor
@mpdudempdude deleted the require_env_processor branchApril 7, 2019 12:26
wouterj added a commit to symfony/symfony-docs that referenced this pull requestApr 7, 2019
…ude)This PR was squashed before being merged into the master branch (closes#11313).Discussion----------Add documentation for the `require` env processorDocumentation forsymfony/symfony#30897, discussed on the FOSSHackathon.Commits-------1011b42 Add documentation for the `require` env processor
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@mpdude@stof@nicolas-grekas@maxhelias@xabbuh@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp