Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DomCrawler] Improve Crawler HTML5 parser need detection#30892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@tgalopin
Copy link
Contributor

@tgalopintgalopin commentedApr 6, 2019•
edited
Loading

QA
Branch?master
Bug fix?kind of
New feature?no
BC breaks?no
Deprecations?no>
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

Live from #eu-fossa

Follow up of#29306

This PR introduces a better detection mechanism to choose when to parse using the HTML5 parser or not, and fix a subcrawler parsing issue as well.

@stof I'd be super interested by your review :) !

@javiereguiluz
Copy link
Member

@tgalopin will you add a config option in FrameworkBundle to enable/disable the HTML5 parser? Thanks.

@tgalopin
Copy link
ContributorAuthor

@javiereguiluz the usage of the HTML5 parser is when 1/ the library is available 2/ the doctype is HTML5. I think it's better than having a configuration option (and was recommended by Nicolas)

fabpot, maxhelias, and javiereguiluz reacted with thumbs up emoji

wouterj added a commit to symfony/symfony-docs that referenced this pull requestApr 6, 2019
…(javiereguiluz)This PR was squashed before being merged into the master branch (closes#11316).Discussion----------Minor improvement in the DomCrawler + HTML5 explanationMinor improvement according to@tgalopin comments insymfony/symfony#30892.Commits-------1c7eb79 Minor improvement in the DomCrawler + HTML5 explanation
@tgalopintgalopinforce-pushed theimprove-html5-crawler-detection branch from96b5f69 to92cd9ecCompareApril 6, 2019 14:52
@tgalopintgalopinforce-pushed theimprove-html5-crawler-detection branch from92cd9ec to9bbdab6CompareApril 6, 2019 14:52
@tgalopin
Copy link
ContributorAuthor

Updated

@fabpot
Copy link
Member

Thank you@tgalopin.

@fabpotfabpot merged commit9bbdab6 intosymfony:masterApr 6, 2019
fabpot added a commit that referenced this pull requestApr 6, 2019
…on (tgalopin)This PR was merged into the 4.3-dev branch.Discussion----------[DomCrawler] Improve Crawler HTML5 parser need detection| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | kind of| New feature?  | no| BC breaks?    | no| Deprecations? | no>| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Live from #eu-fossaFollow up of#29306This PR introduces a better detection mechanism to choose when to parse using the HTML5 parser or not, and fix a subcrawler parsing issue as well.@stof I'd be super interested by your review :) !Commits-------9bbdab6 [DomCrawler] Improve Crawler HTML5 parser need detection
@tgalopintgalopin deleted the improve-html5-crawler-detection branchApril 6, 2019 16:17
@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 7, 2019
@nicolas-grekasnicolas-grekas removed this from thenext milestoneApr 30, 2019
@nicolas-grekasnicolas-grekas added this to the4.3 milestoneApr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
nicolas-grekas added a commit that referenced this pull requestMay 9, 2019
This PR was merged into the 4.3 branch.Discussion----------[DomCrawler] fix HTML5 parser integration| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Spotted while reviewing#30892The current logic is context-dependent: by changing the order of calls, you can get different behaviors.Commits-------ba83bda [DomCrawler] fix HTML5 parser integration
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus requested changes

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

+2 more reviewers

@ostroluckyostroluckyostrolucky requested changes

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

10 participants

@tgalopin@javiereguiluz@fabpot@stof@ostrolucky@derrabus@maxhelias@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp