Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Workflow] Changed initial_places to initial_marking, added property#30890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 3 commits intosymfony:masterfromlyrixx:workflow-initial-marking
Apr 6, 2019

Conversation

@lyrixx
Copy link
Member

@lyrixxlyrixx commentedApr 6, 2019
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#30662 and#30656
LicenseMIT
Doc PR#30656

EUFOSSA


  • [Workflow] Changed initial_places to initial_marking, added property instead of type
  • [Workflow] Finished integration of initial_marking + deprecated support for workflow + single state markin store
    [Workflow] Deprecate worflow and single state marking

Here is an exemple of deprecation:

                                                                                                                                                                               3x: Passing something else than "method" has been deprecated in Symfony 4.3.                                                                                                   1x in PhpFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection                                                            1x in XmlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection                                                            1x in YamlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection                                                                                                                                                                                                                                      3x: The "framework.workflows.workflows.legacy.marking_store.arguments" configuration key has been deprecated in Symfony 4.3. Use "property" instead.                           1x in PhpFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection                                                            1x in XmlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection                                                            1x in YamlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection                                                                                                                                                                                                                                      3x: The "framework.workflows.workflows.legacy.initial_place" configuration key has been deprecated in Symfony 4.3, use the "initial_marking" configuration key instead.        1x in PhpFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection                                                            1x in XmlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection                                                            1x in YamlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection

@lyrixx
Copy link
MemberAuthor

@HeahDude Could you review this PR? 🙏

@lyrixxlyrixxforce-pushed theworkflow-initial-marking branch fromf4347b5 to0393535CompareApril 6, 2019 13:39
Copy link
Contributor

@HeahDudeHeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice!

@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commit0393535 intosymfony:masterApr 6, 2019
fabpot added a commit that referenced this pull requestApr 6, 2019
…added property (HeahDude, lyrixx)This PR was merged into the 4.3-dev branch.Discussion----------[Workflow] Changed initial_places to initial_marking, added property| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#30662 and#30656| License       | MIT| Doc PR        |#30656EUFOSSA---* [Workflow] Changed initial_places to initial_marking, added property instead of type* [Workflow] Finished integration of initial_marking + deprecated support for workflow + single state markin store [Workflow] Deprecate worflow and single state marking---Here is an exemple of deprecation:```  3x: Passing something else than "method" has been deprecated in Symfony 4.3.    1x in PhpFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection    1x in XmlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection    1x in YamlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection  3x: The "framework.workflows.workflows.legacy.marking_store.arguments" configuration key has been deprecated in Symfony 4.3. Use "property" instead.    1x in PhpFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection    1x in XmlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection    1x in YamlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection  3x: The "framework.workflows.workflows.legacy.initial_place" configuration key has been deprecated in Symfony 4.3, use the "initial_marking" configuration key instead.    1x in PhpFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection    1x in XmlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection    1x in YamlFrameworkExtensionTest::testWorkflowLegacy from Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection  ```Commits-------0393535 [Workflow] Deprecate worflow and single state marking87839cf [Workflow] Finished integration of initial_marking + deprecated support for workflow + single state markin store73708a6 [Workflow] Changed initial_places to initial_marking, added property instead of type
@lyrixxlyrixx deleted the workflow-initial-marking branchApril 6, 2019 17:09
@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 6, 2019
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
wouterj added a commit to symfony/symfony-docs that referenced this pull requestAug 12, 2019
This PR was merged into the 4.3 branch.Discussion----------[4.3] Update workflow configRescued some really bad git stuff from me while merging:#11580Original description:> Hi,>> This draft PR follows this one>https://github.com/symfony/symfony-docs/pull/11492/files (config for 3.X version)> but for new version, mostly 4.3>> I checked this PR also>symfony/symfony#30890,@lyrixx review appreciated please>> Maybe to merge after merging#11578, and with a rebase ?>> -------------------->> Draft for now>> -Closes#11229>> this one can be closed also:>> -Closes#9475> -Closes#10197Commits-------fdc221b Minor XML improvementa640d14 [Workflow] config doc7bb2041 Fix indentf65f1bc Reviewcf3a32c Doc config metadata34e7cc5 [Workflow] config doc
fabpot added a commit that referenced this pull requestJan 10, 2020
…_marking" (phansys)This PR was merged into the 4.3 branch.Discussion----------[Workflow] Fix configuration node reference for "initial_marking"| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | no| New feature?  | no| Deprecations? | no| Related to       |#30890| License       | MITCommits-------452f925 [Workflow] Fix configuration node reference for "initial_marking"
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@HeahDudeHeahDudeHeahDude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DeprecationDXDX = Developer eXperience (anything that improves the experience of using Symfony)FeatureStatus: ReviewedWorkflow

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@lyrixx@fabpot@HeahDude@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp