Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DependencyInjection] Fix a wrong error when using a factory#30889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:3.4fromSimperfit:bugfix/ignore-wrong-error-on-interfaceApr 6, 2019
Merged
[DependencyInjection] Fix a wrong error when using a factory#30889
fabpot merged 1 commit intosymfony:3.4fromSimperfit:bugfix/ignore-wrong-error-on-interfaceApr 6, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6981fff to9b8397bComparejderusse approved these changesApr 6, 2019
Member
jderusse left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Reproduced on my app environment.
Work for me
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
ad4c735 to66f6e8eComparetgalopin approved these changesApr 6, 2019
fabpot approved these changesApr 6, 2019
Member
fabpot commentedApr 6, 2019
Should probably be applied on 3.4 or 4.2 |
66f6e8e to5d4e3a2CompareMember
fabpot commentedApr 6, 2019
Thank you@Simperfit. |
fabpot added a commit that referenced this pull requestApr 6, 2019
…ry (Simperfit)This PR was merged into the 3.4 branch.Discussion----------[DependencyInjection] Fix a wrong error when using a factory…d a call| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#30885 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR |<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->This a work in progress, it needs tests, firstly I wanted to ask the author to test and tell if it's ok.Commits-------5d4e3a2 [WIP] [DependencyInjection] Fix a wrong error when using a factory and a call
nicolas-grekas added a commit that referenced this pull requestNov 28, 2019
…s pass (fancyweb)This PR was merged into the 4.4 branch.Discussion----------[DI] Skip unknown method calls for factories in check types pass| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#34559| License | MIT| Doc PR | -Ref#30885 and#30889.Commits-------592bff8 [DI] Skip unknown method calls for factories in check types pass
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestNov 28, 2019
…s pass (fancyweb)This PR was merged into the 4.4 branch.Discussion----------[DI] Skip unknown method calls for factories in check types pass| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |symfony/symfony#34559| License | MIT| Doc PR | -Refsymfony/symfony#30885 andsymfony/symfony#30889.Commits-------592bff88f2 [DI] Skip unknown method calls for factories in check types pass
symfony-splitter pushed a commit to symfony/dependency-injection that referenced this pull requestNov 28, 2019
…s pass (fancyweb)This PR was merged into the 4.4 branch.Discussion----------[DI] Skip unknown method calls for factories in check types pass| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |symfony/symfony#34559| License | MIT| Doc PR | -Refsymfony/symfony#30885 andsymfony/symfony#30889.Commits-------592bff88f2 [DI] Skip unknown method calls for factories in check types pass
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d a call
This a work in progress, it needs tests, firstly I wanted to ask the author to test and tell if it's ok.