Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] fix search in debug autowiring#30887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Simperfit
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30493
LicenseMIT
Doc PR

Taking#30522 and finishing it with@nicolas-grekas comments.
Is the sentence ok ?

@SimperfitSimperfitforce-pushed thefeature/fix-search-in-debug-autowiring branch 2 times, most recently fromcff1c8e tobfe246cCompareApril 6, 2019 12:39
@Simperfit
Copy link
ContributorAuthor

Simperfit commentedApr 6, 2019•
edited
Loading

@chalasr@fabpot PR is ready, the message has been changed.

@SimperfitSimperfitforce-pushed thefeature/fix-search-in-debug-autowiring branch 2 times, most recently fromcbec3df to92155ecCompareApril 6, 2019 15:23
@Simperfit
Copy link
ContributorAuthor

@nicolas-grekas updated

@soufianZantar
Copy link
Contributor

soufianZantar commentedApr 6, 2019•
edited
Loading

I spent my time in debbuging and crating my PR, and i waiting for the back from 24days,@Simperfit it's normal for you to create new PR after the back of@nicolas-grekas ????

@chalasr it's normal to close my PR and not this PR?

@SimperfitSimperfitforce-pushed thefeature/fix-search-in-debug-autowiring branch from92155ec toc965a17CompareApril 6, 2019 15:49
@Simperfit
Copy link
ContributorAuthor

@soufianZantar Firstly Thanks very much for the contribution to the Symfony framework, We are at a hackathon, we wanted to move things forward by taking the stalling PRs to finish them.

You still have the work done with the commit included in the PR, again thanks very much, I just took what you have done and updated it while talking to@nicolas-grekas.

soufianZantar reacted with thumbs up emoji

@SimperfitSimperfitforce-pushed thefeature/fix-search-in-debug-autowiring branch fromc965a17 toa535bdbCompareApril 6, 2019 16:31
@soufianZantar
Copy link
Contributor

Ok, I understood now. No problem.

greg0ire, chalasr, and Simperfit reacted with heart emoji

@greg0ire
Copy link
Contributor

greg0ire commentedApr 6, 2019•
edited
Loading

If you want to get credit for that PR, you can do so by associating the email address for what seems to be an alternate account (@sez-open ?) to your@soufianZantar account. With love from the hackathon:https://twitter.com/hashtag/EUFOSSA

chalasr and soufianZantar reacted with thumbs up emoji

@SimperfitSimperfitforce-pushed thefeature/fix-search-in-debug-autowiring branch froma535bdb tofec4beaCompareApril 7, 2019 07:27
@nicolas-grekas
Copy link
Member

Thank you@Simperfit.

@nicolas-grekasnicolas-grekas merged commitfec4bea intosymfony:masterApr 7, 2019
nicolas-grekas added a commit that referenced this pull requestApr 7, 2019
…open)This PR was merged into the 4.3-dev branch.Discussion----------[FrameworkBundle] fix search in debug autowiring| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#30493   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        |<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Taking#30522 and finishing it with@nicolas-grekas comments.Is the sentence ok ?Commits-------fec4bea fix debug:autowiringcommand
@nicolas-grekas
Copy link
Member

And thank you@soufianZantar

soufianZantar reacted with thumbs up emojiOskarStark and Simperfit reacted with heart emoji

@SimperfitSimperfit deleted the feature/fix-search-in-debug-autowiring branchApril 7, 2019 12:12
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

8 participants

@Simperfit@soufianZantar@greg0ire@nicolas-grekas@fabpot@chalasr@carsonbot@sez-open
[8]ページ先頭
©2009-2025 Movatter.jp