Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

minor: remove the logger as it seems uneeded#30880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromSimperfit:minor/no-parameters
Apr 6, 2019

Conversation

@Simperfit
Copy link
Contributor

@SimperfitSimperfit commentedApr 6, 2019
edited
Loading

QA
Branch?master for features
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsnone
LicenseMIT
Doc PRnot needed

It seems that the logger is not used in here cc@nicolas-grekas, to close if it's the wanted code.
#euchackaton

Copy link
Contributor

@OcramiusOcramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@fabpot
Copy link
Member

Thank you@Simperfit.

@fabpotfabpot merged commit4fc6033 intosymfony:masterApr 6, 2019
fabpot added a commit that referenced this pull requestApr 6, 2019
This PR was merged into the 4.3-dev branch.Discussion----------minor: remove the logger as it seems uneeded| Q             | A| ------------- | ---| Branch?       | master for features| Bug fix?      | no| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | none  <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | not needed<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->It seems that the logger is not used in here cc@nicolas-grekas, to close if it's the wanted code.#euchackatonCommits-------4fc6033 minor: remove the logger as it seems uneeded
@SimperfitSimperfit deleted the minor/no-parameters branchApril 7, 2019 12:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@OcramiusOcramiusOcramius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Simperfit@fabpot@Ocramius@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp