Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] Adjust logger messages and levels#30873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lyrixx commentedApr 5, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
joelwurtz commentedApr 5, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
What about adding url / method / and other variables as attributes in the log message ? would be useful for some systems parsing logs so we could filters logs. |
lyrixx commentedApr 5, 2019
I already make app that heavily use an http client with a nice log platform, and I never add such need. So you really think it common to search by verb or URL ? |
lyrixx commentedApr 5, 2019
@nicolas-grekas About warning vs debug: Warning do not spam the logs. I suppose you are referring to the FingerCrossHandler. But the threshold is More over:
So, maybe some warning should goes to debug. But I'm not sure it's the case for all of them. $this->logger &&$this->logger->info(sprintf('Rejecting pushed response for "%s": authorization headers don\'t match the request',$url)); Could you re-review this PR with theses new considerations? Thanks |
nicolas-grekas commentedApr 5, 2019
@lyrixx the HTTP/2 spec lists that clients should be defensive against servers that send too many pushes or other frames. That means this is not rare, when it's spamming. |
lyrixx commentedApr 5, 2019
@nicolas-grekas Ok. I changed all warning to debug, and updated all |
nicolas-grekas commentedApr 5, 2019
Thank you@lyrixx. |
This PR was squashed before being merged into the 4.3-dev branch (closes#30873).Discussion----------[HttpClient] Adjust logger messages and levels| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------098a7ac [HttpClient] Adjust logger messages and levels