Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] test DoctrineTransport on travis and appveyor#30857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@vincenttouzet
Copy link
Contributor

@vincenttouzetvincenttouzet commentedApr 3, 2019•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes ? WIP
Fixed tickets
LicenseMIT
Doc PR

Currently tests on theSymfony\Component\Messenger\Tests\Transport\Doctrine\DoctrineIntegrationTest are skipped because there is noMESSENGER_DOCTRINE_DSN environment variable is not defined.

This PR update the travis and AppVeyor configuration to run these tests.

This is a WIP. I'm not a Travis/AppVeyor user so this clearly need more work

@vincenttouzetvincenttouzetforce-pushed thetravis-messenger-doctrine branch 2 times, most recently from25c3cbc todf21cf4CompareApril 3, 2019 20:17
@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 4, 2019
@vincenttouzetvincenttouzetforce-pushed thetravis-messenger-doctrine branch 3 times, most recently from3c62139 to3a41769CompareApril 4, 2019 18:04
@vincenttouzet
Copy link
ContributorAuthor

vincenttouzet commentedApr 4, 2019•
edited
Loading

Thx for the help@nicolas-grekas .Do you know how can I run test with deps=low locally ? I triedcomposer update --prefer-lowest --prefer-stable but I got errors and no tests are runned :(

Nervermind juste runcomposer up --prefer-lowest --prefer-stable thenSYMFONY_PHPUNIT_VERSION=6.5.13 php phpunit src/Symfony/Component/Messenger/ and its fine :)

EDIT: Well ... this installdoctrine/dbalv2.6.0 locally but it fails on travis withv2.4.0

@nicolas-grekasnicolas-grekasforce-pushed thetravis-messenger-doctrine branch from666b212 to00ceb4aCompareApril 5, 2019 13:03
@nicolas-grekasnicolas-grekas changed the titleRFC [Messenger] Add MESSENGER_DOCTRINE_DSN for travis and appveyor[Messenger] test DoctrineTransport on travis and appveyorApr 5, 2019
@nicolas-grekasnicolas-grekasforce-pushed thetravis-messenger-doctrine branch 2 times, most recently frome6043de to488a8d8CompareApril 5, 2019 13:19
@nicolas-grekas
Copy link
Member

cd src/Symfony/Component/Messenger/composer up --prefer-lowest --prefer-stable../../../../phpunit
vincenttouzet reacted with thumbs up emoji

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(I pushed the remaining fixes to make tests pass)

@nicolas-grekasnicolas-grekasforce-pushed thetravis-messenger-doctrine branch from488a8d8 to8f81f55CompareApril 5, 2019 14:21
Copy link
Member

@weaverryanweaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The date changes do not cause any functionality loss as doctrine/dbal already didn’t support ms in DateTime (so delays already we’re in second precision, not ms, before this PR)

vincenttouzet reacted with thumbs up emoji
@sroze
Copy link
Contributor

Thank you@vincenttouzet.

@srozesroze merged commit8f81f55 intosymfony:masterApr 6, 2019
sroze added a commit that referenced this pull requestApr 6, 2019
…r (vincenttouzet)This PR was merged into the 4.3-dev branch.Discussion----------[Messenger] test DoctrineTransport on travis and appveyor| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes ? WIP| Fixed tickets || License       | MIT| Doc PR        |Currently tests on the `Symfony\Component\Messenger\Tests\Transport\Doctrine\DoctrineIntegrationTest` are skipped because there is no `MESSENGER_DOCTRINE_DSN` environment variable is not defined.This PR update the travis and AppVeyor configuration to run these tests.This is a WIP. I'm not a Travis/AppVeyor user so this clearly need more workCommits-------8f81f55 [Messenger] test DoctrineTransport on travis and appveyor
@vincenttouzetvincenttouzet deleted the travis-messenger-doctrine branchApril 7, 2019 07:43
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@weaverryanweaverryanweaverryan approved these changes

+1 more reviewer

@srozesrozesroze approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@vincenttouzet@nicolas-grekas@sroze@weaverryan@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp