Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] Improve constraint default option check#30737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:3.4fromvudaltsov:constraint-annotation-undefined-default-optionMar 29, 2019
Merged
[Validator] Improve constraint default option check#30737
fabpot merged 1 commit intosymfony:3.4fromvudaltsov:constraint-annotation-undefined-default-optionMar 29, 2019
+27 −15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fabpot added a commit that referenced this pull requestMar 29, 2019
…(vudaltsov)This PR was squashed before being merged into the 3.4 branch (closes#30736).Discussion----------[Validator] Fix annotation default for@count and@Length| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | n/a| License | MIT| Doc PR | is it worth mentioning?`Count` and `Length` constraints allow to pass the exact value as the constructor argument when used in code.```phpnew Length(5);// is same asnew Length(['min' => 5, 'max' => 5]);```At the same time when using them as annotations, `@Assert\Length(5)` throws `The options "" do not exist in constraint Symfony\\Component\\Validator\\Constraints\\Length` (fix for ugly exception is proposed in#30737). This happens because annotation's default value is passed as `value`. Since `Length` does not have a default option, `value` is replaced with `''`.This PR fixes this inconsistency.Commits-------7bfb8c1 [Validator] Fix annotation default for@count and@Length
fabpot approved these changesMar 29, 2019
Member
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
minor comment to be fixed.
Uh oh!
There was an error while loading.Please reload this page.
ContributorAuthor
vudaltsov commentedMar 29, 2019
@fabpot , done. Also fixed other messages in the |
b04345d to915912eCompareMember
fabpot commentedMar 29, 2019
Thank you@vudaltsov. |
fabpot added a commit that referenced this pull requestMar 29, 2019
…tsov)This PR was squashed before being merged into the 3.4 branch (closes#30737).Discussion----------[Validator] Improve constraint default option check| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aAny constraint without default option used as annotation with unnamed first argument (for example, `@Assert\Collection(1)`) throws an exception with an ugly message `The options "" do not exist in constraint Collection`.This PR makes constraint check the default option in the annotation case in the same way it checks it in the "real" code case. So the exception will be `No default option is configured for constraint Collection.`Commits-------915912e [Validator] Improve constraint default option check
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Any constraint without default option used as annotation with unnamed first argument (for example,
@Assert\Collection(1)) throws an exception with an ugly messageThe options "" do not exist in constraint Collection.This PR makes constraint check the default option in the annotation case in the same way it checks it in the "real" code case. So the exception will be
No default option is configured for constraint Collection.