Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyInfo] Add possibility to extract private and protected properties in reflection extractor#30706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:masterfromjoelwurtz:feature/private-reflection-extractorMar 27, 2019
Merged
[PropertyInfo] Add possibility to extract private and protected properties in reflection extractor#30706
fabpot merged 1 commit intosymfony:masterfromjoelwurtz:feature/private-reflection-extractorMar 27, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedMar 26, 2019
fabpot approved these changesMar 26, 2019
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…rties in reflection extractor
8cafd2e to05e487fCompareMember
fabpot commentedMar 27, 2019
Thank you@joelwurtz. |
fabpot added a commit that referenced this pull requestMar 27, 2019
…protected properties in reflection extractor (joelwurtz)This PR was squashed before being merged into the 4.3-dev branch (closes#30706).Discussion----------[PropertyInfo] Add possibility to extract private and protected properties in reflection extractor| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#30248| License | MIT| Doc PR | TODOThis PR add the possibility to extract private and protected properties from a class by passing a new argument to the `ReflectionExtractor`This new argument consist of flag that filters properties, so someone will also be able to use the `ReflectionExtractor` only for private property```phpnew ReflectionExtractor(null, null, null, true, ReflectionExtractor::ALLOW_PRIVATE | ReflectionExtractor::ALLOW_PROTECTED)```Flags method was prefered over a list of bool to avoid too many parameters and also be close to the reflection API of PHPCommits-------05e487f [PropertyInfo] Add possibility to extract private and protected properties in reflection extractor
nicolas-grekas added a commit that referenced this pull requestMar 28, 2019
…cted (joelwurtz)This PR was merged into the 4.3-dev branch.Discussion----------[PropertyInfo] Add missing changelog for private / protected| Q | A| ------------- | ---| Branch? | master| Bug fix? | somehow| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Add missing changelog for#30706Commits-------8c5663d Add missing changelog for private / protected
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestApr 1, 2019
This PR was squashed before being merged into the master branch (closes#11247).Discussion----------Documented the new Unique constraintDocumentssymfony/symfony#30706Commits-------4b2007e Documented the new Unique constraint
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR add the possibility to extract private and protected properties from a class by passing a new argument to the
ReflectionExtractorThis new argument consist of flag that filters properties, so someone will also be able to use the
ReflectionExtractoronly for private propertyFlags method was prefered over a list of bool to avoid too many parameters and also be close to the reflection API of PHP