Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PropertyInfo] Add possibility to extract private and protected properties in reflection extractor#30706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@joelwurtz
Copy link
Contributor

@joelwurtzjoelwurtz commentedMar 26, 2019
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30248
LicenseMIT
Doc PRTODO

This PR add the possibility to extract private and protected properties from a class by passing a new argument to theReflectionExtractor

This new argument consist of flag that filters properties, so someone will also be able to use theReflectionExtractor only for private property

newReflectionExtractor(null,null,null,true, ReflectionExtractor::ALLOW_PRIVATE | ReflectionExtractor::ALLOW_PROTECTED)

Flags method was prefered over a list of bool to avoid too many parameters and also be close to the reflection API of PHP

@joelwurtzjoelwurtz changed the titleAdd possibility to extract private and protected properties in reflection extractor[PropertyInfo] Add possibility to extract private and protected properties in reflection extractorMar 26, 2019
@fabpotfabpotforce-pushed thefeature/private-reflection-extractor branch from8cafd2e to05e487fCompareMarch 27, 2019 06:41
@fabpot
Copy link
Member

Thank you@joelwurtz.

@fabpotfabpot merged commit05e487f intosymfony:masterMar 27, 2019
fabpot added a commit that referenced this pull requestMar 27, 2019
…protected properties in reflection extractor (joelwurtz)This PR was squashed before being merged into the 4.3-dev branch (closes#30706).Discussion----------[PropertyInfo] Add possibility to extract private and protected properties in reflection extractor| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30248| License       | MIT| Doc PR        | TODOThis PR add the possibility to extract private and protected properties from a class by passing a new argument to the `ReflectionExtractor`This new argument consist of flag that filters properties, so someone will also be able to use the `ReflectionExtractor` only for private property```phpnew ReflectionExtractor(null, null, null, true, ReflectionExtractor::ALLOW_PRIVATE | ReflectionExtractor::ALLOW_PROTECTED)```Flags method was prefered over a list of bool to avoid too many parameters and also be close to the reflection API of PHPCommits-------05e487f [PropertyInfo] Add possibility to extract private and protected properties in reflection extractor
nicolas-grekas added a commit that referenced this pull requestMar 28, 2019
…cted (joelwurtz)This PR was merged into the 4.3-dev branch.Discussion----------[PropertyInfo] Add missing changelog for private / protected| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | somehow| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Add missing changelog for#30706Commits-------8c5663d Add missing changelog for private / protected
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestApr 1, 2019
This PR was squashed before being merged into the master branch (closes#11247).Discussion----------Documented the new Unique constraintDocumentssymfony/symfony#30706Commits-------4b2007e Documented the new Unique constraint
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
@joelwurtzjoelwurtz deleted the feature/private-reflection-extractor branchMay 9, 2019 07:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@xabbuhxabbuhxabbuh left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@joelwurtz@fabpot@nicolas-grekas@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp