Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Finder] Get filename without extension#30664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@antonch1989
Copy link
Contributor

@antonch1989antonch1989 commentedMar 24, 2019•
edited by nicolas-grekas
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30655
LicenseMIT
Doc PR

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for this contribution, please fix the table in the PR header, because this is no bugfix, but a feature.

@nicolas-grekasnicolas-grekas added this to thenext milestoneMar 25, 2019
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, let's a minor comment.

@fabpotfabpotforce-pushed theissue-30655-filename-without-extension branch from137f287 to821e55aCompareMarch 27, 2019 08:36
@fabpot
Copy link
Member

Thank you@antonch1989.

@fabpotfabpot merged commit821e55a intosymfony:masterMar 27, 2019
fabpot added a commit that referenced this pull requestMar 27, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes#30664).Discussion----------[Finder] Get filename without extension| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30655| License       | MIT| Doc PR        |Commits-------821e55a [Finder] Get filename without extension
@OskarStark
Copy link
Contributor

Thank you for this contribution, can you please add some documentation for this new feature?

@javiereguiluz
Copy link
Member

I find this method confusing. It's calledgetFilenameWithoutExtension() but sometimes it returns the filename + extension:

getFilenameWithoutExtension('foo.html');// foogetFilenameWithoutExtension('foo.html.twig');// foo.htmlgetFilenameWithoutExtension('foo.tar.gz');// foo.tar

I expectedfoo as the returned value in all cases.

@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@antonch1989@fabpot@OskarStark@javiereguiluz@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp