Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Bridge][Twig] DebugCommand - fix escaping and filter#30660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromSpacePossum:3_4_Twig_DebugCommand.php
Mar 31, 2019

Conversation

@SpacePossum
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
LicenseMIT

The PR fixes:

  • output escaping was not done for decorated consoles
  • filter was not applied when using format json
  • added some tests for paths currently not tested

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

with a typo to be fixed before merging.

@fabpotfabpotforce-pushed the3_4_Twig_DebugCommand.php branch from80818ef to7bdb066CompareMarch 31, 2019 11:33
@fabpot
Copy link
Member

Thank you@SpacePossum.

@fabpotfabpot merged commit7bdb066 intosymfony:3.4Mar 31, 2019
fabpot added a commit that referenced this pull requestMar 31, 2019
…cePossum)This PR was squashed before being merged into the 3.4 branch (closes#30660).Discussion----------[Bridge][Twig] DebugCommand - fix escaping and filter| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MITThe PR fixes:- output escaping was not done for decorated consoles- filter was not applied when using format json+ added some tests for paths currently not testedCommits-------7bdb066 [Bridge][Twig] DebugCommand - fix escaping and filter
@SpacePossumSpacePossum deleted the 3_4_Twig_DebugCommand.php branchMarch 31, 2019 13:31
@nicolas-grekas
Copy link
Member

@SpacePossum I did not merge your patch on the bridge in 4.2 because I couldn't figure out how to resolve merge conflicts. Could you please send a PR against 4.2?

@SpacePossum
Copy link
ContributorAuthor

sure thing@nicolas-grekas , please see#30811

fabpot added a commit that referenced this pull requestApr 1, 2019
…pacePossum)This PR was merged into the 4.2 branch.Discussion----------[Bridge][Twig] DebugCommand - fix escaping and filter| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MITcherry-pick on 4.2, conflicts resolved, original PR#30660 (comment)Commits-------b7120c5 [Bridge][Twig] DebugCommand - fix escaping and filter
This was referencedApr 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@SpacePossum@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp