Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Debug finalized config in debug:config#30648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.2fromro0NL:debug-conf
Mar 23, 2019
Merged

Debug finalized config in debug:config#30648

fabpot merged 1 commit intosymfony:4.2fromro0NL:debug-conf
Mar 23, 2019

Conversation

@ro0NL
Copy link
Contributor

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30637
LicenseMIT
Doc PRsymfony/symfony-docs#...

Re-processing the extension config indebug:config causes a lot of steps to be ignored, basically everything inValidateEnvPlaceholdersPass.

As such we trigger a misleading error when this command is invoked.

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedMar 22, 2019
edited
Loading

$ bin/console debug:config SecurityBundle# before  Invalid type for path "security.firewalls.api_login.security". Expected boolean, but got string.  # afterCurrent configuration for "SecurityBundle"==========================================security:    firewalls:        api_login:            security: '%env(bool:FOO)%'            anonymous:                secret: '%env(int:FOO)%'

@ro0NL
Copy link
ContributorAuthor

deps=high should pass after merge.

@chalasrchalasr modified the milestones:next,4.2Mar 23, 2019
@fabpot
Copy link
Member

Thank you@ro0NL.

@fabpotfabpot merged commitb9ac3a5 intosymfony:4.2Mar 23, 2019
fabpot added a commit that referenced this pull requestMar 23, 2019
This PR was merged into the 4.2 branch.Discussion----------Debug finalized config in debug:config| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#30637| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Re-processing the extension config in `debug:config` causes a lot of steps to be ignored, basically everything in `ValidateEnvPlaceholdersPass`.As such we trigger a misleading error when this command is invoked.Commits-------b9ac3a5 Debug finalized config in debug:config
@ro0NLro0NL deleted the debug-conf branchMarch 24, 2019 09:43
@fabpotfabpot mentioned this pull requestApr 2, 2019
fabpot added a commit that referenced this pull requestAug 26, 2021
…bug:config and consistently resolve parameter values (herndlm)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle] Fall back to default configuration in debug:config and consistently resolve parameter values| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#41121| License       | MIT| Doc PR        | n/aBrings back determining the default configuration from pull request#30648. Refactors determining the extension config into a helper method to keep cognitive load low with early exits instead of nested ifs.Additionaly, while reviewing, we noticed that entries with parameters are not resolved correctly if they come from the default config and an application config is existing but they are not overriden. E.g. the session config for the framework would output `save_path: %kernel.cache_dir%/sessions` instead of the resolved value.Tested via unit test (obviously) and by manually removing bundle configuration in a Symfony project.Beware that I do not know much about bundles and internals, I looked that up while implementing this and might have missed better/simpler solutions or edge cases. Please somebody also do another functional test to ensure this is really working as it should.Commits-------9b6110b [FrameworkBundle] Fall back to default configuration in debug:config and consistently resolve parameter values
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@ro0NL@fabpot@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp