Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][HttpFoundation] make session service resettable#30620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
6e670cd to08b1daeComparenicolas-grekas commentedMar 20, 2019
Before merging: the way tests are written is not compatible with phpunit 4.8. |
dmaicher commentedMar 21, 2019
@nicolas-grekas because of I find quite a lot of usages of that in the 3.4 branch. |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(failure unrelated)
fabpot commentedMar 23, 2019
Thank you@dmaicher. |
…ettable (dmaicher)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle][HttpFoundation] make session service resettable| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#30619| License | MIT| Doc PR | -Thisfixes#30619 by making the session service "resettable" via `ServicesResetter`.Commits-------e46ef76 [FrameworkBundle][HttpFoundation] make session service resettable
Chi-teck commentedApr 6, 2019
This caused a critical issue in Drupal 8. |
dmaicher commentedApr 6, 2019
@Chi-teck sorry to hear that. Please open an issue if you think we should discuss/track this. |
mdlutz24 commentedApr 23, 2019
The issue in drupal was that we use a custom session storage such that if a user is not logged into the website then we don't start the session UNTIL something is saved to prevent setting cookies unnecessarily. Since our storage save function isn't called anymore until the session is started, we don't save the session at all anymore. Our initial workaround was to adjust our isStarted method to return true after bootstrap, but we are finding that is causing problems in other places that depend on isStarted() to tell us whether the session is actually started or not. Might it make sense to move the responsibility for checking if the session is started from Session::save and into SessionStorageInterface::save? This would avoid the BC issues for custom storage that depended on managing whether they should save or not on their own, but still allow for the bug fix for the bundled storage classes. |
…session service resettable (dmaicher)" (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------Revert "bug#30620 [FrameworkBundle][HttpFoundation] make session service resettable (dmaicher)"| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This reverts commit029fb2e, reversingchanges made to9dad29d.Reverts#30620Replaces#31215We don't need to solve this in 3.4Making the session resettable should be done on master, by implementing `ResetInterface`.On 3.4 apps, one should write a dedicated `SessionResetter` that would implement the reverted logic.Commits-------4177331 Revert "bug#30620 [FrameworkBundle][HttpFoundation] make session service resettable (dmaicher)"
* 3.4: Revert "bug#30620 [FrameworkBundle][HttpFoundation] make session service resettable (dmaicher)" [Workflow] Fixed dumping when many transition with same name exist fix ConsoleFormatter - call to a member function format() on string
* 4.2: Revert "bug#30620 [FrameworkBundle][HttpFoundation] make session service resettable (dmaicher)" [Workflow] Fixed dumping when many transition with same name exist relax assertions in tests fix ConsoleFormatter - call to a member function format() on string Made `debug:container` and `debug:autowiring` ignore starting backslash in service id [Validator] Translate messages into Japanese Fix Thai translation in validators.th.xlf [FramworkBundle] mark any env vars found in the ide setting as used
Thisfixes#30619 by making the session service "resettable" via
ServicesResetter.