Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpClient] Make exceptions public#30549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromdunglas:non-internal-exceptions
Mar 17, 2019

Conversation

@dunglas
Copy link
Member

@dunglasdunglas commentedMar 13, 2019
edited
Loading

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRn/a

Makes it easier to implement the interface. Seeapi-platform/core#2608

@nicolas-grekasnicolas-grekas added this to thenext milestoneMar 13, 2019
@fabpotfabpotforce-pushed thenon-internal-exceptions branch from9f985b4 to928d774CompareMarch 17, 2019 07:23
@fabpot
Copy link
Member

Thank you@dunglas.

@fabpotfabpot merged commit928d774 intosymfony:masterMar 17, 2019
fabpot added a commit that referenced this pull requestMar 17, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes#30549).Discussion----------[HttpClient] Make exceptions public| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no<!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | n/aMakes it easier to implement the interface. Seeapi-platform/core#2608Commits-------928d774 [HttpClient] Make exceptions public
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
fabpot added a commit that referenced this pull requestMay 10, 2020
This PR was merged into the 5.1-dev branch.Discussion----------[HttpClient] add TimeoutExceptionInterface| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -This is fixing a design issue: unlike any other `TransportExceptionInterface`, timeouts are not fatal transport errors. For this reason, we must allow one to identify them.~This PR also marks exception classes as `@internal`, to encourage ppl to catch them using their interface and not their class name.~ this would revert#30549Commits-------ab8eca0 [HttpClient] add TimeoutExceptionInterface
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@dunglas@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp