Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[framworkbundle] fix search in debug:autowiring command#30522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@soufianZantar
Copy link
Contributor

@soufianZantarsoufianZantar commentedMar 11, 2019
edited by javiereguiluz
Loading

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30493
LicenseMIT
Doc PRsymfony/symfony-docs#...

When searching for autowiring class :

If the class not found the command return exception[ERROR] No autowirable classes or interfaces found matching "fake"

But After adding the optionall to the command ( To shwing no aliased services), if someone search for no aliased services without the optionall. the command command will return empty result and not exception.

I suggested if someone adding search argument. the command must return the aliased and no aliased services. I think it would be better to return the aliased and no aliased services for devs.

@chalasrchalasr added this to the4.2 milestoneMar 12, 2019
@nicolas-grekas
Copy link
Member

Unless--all is passed, we should not list non-aliases services to me, even when searching.
What we could do instead is display some short sentence telling there are more results than displayed. This could also tell it is not recommended to type-hint classes if possible.

@chalasr
Copy link
Member

Closing in favor of#30887, thank you for the PR!

@chalasrchalasr closed thisApr 6, 2019
nicolas-grekas added a commit that referenced this pull requestApr 7, 2019
…open)This PR was merged into the 4.3-dev branch.Discussion----------[FrameworkBundle] fix search in debug autowiring| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#30493   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        |<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Taking#30522 and finishing it with@nicolas-grekas comments.Is the sentence ok ?Commits-------fec4bea fix debug:autowiringcommand
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@soufianZantar@nicolas-grekas@chalasr@carsonbot@sez-open

[8]ページ先頭

©2009-2025 Movatter.jp