Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[framworkbundle] fix search in debug:autowiring command#30522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedApr 5, 2019
Unless |
chalasr commentedApr 6, 2019
Closing in favor of#30887, thank you for the PR! |
…open)This PR was merged into the 4.3-dev branch.Discussion----------[FrameworkBundle] fix search in debug autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#30493 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR |<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Taking#30522 and finishing it with@nicolas-grekas comments.Is the sentence ok ?Commits-------fec4bea fix debug:autowiringcommand
Uh oh!
There was an error while loading.Please reload this page.
When searching for autowiring class :
If the class not found the command return exception
[ERROR] No autowirable classes or interfaces found matching "fake"But After adding the optionall to the command ( To shwing no aliased services), if someone search for no aliased services without the optionall. the command command will return empty result and not exception.
I suggested if someone adding search argument. the command must return the aliased and no aliased services. I think it would be better to return the aliased and no aliased services for devs.