Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[RouterDebugCommand] add link to Controllers#30520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
1521372 to6dd8ce5Compare0238846 to847a50bCompareUh oh!
There was an error while loading.Please reload this page.
Member
fabpot commentedMar 31, 2019
@nicoweb Can you have a look at the comments and fix this PR accordingly? Thank you. |
847a50b tod90c9faCompared90c9fa toe9fca21Comparechalasr approved these changesApr 3, 2019
Uh oh!
There was an error while loading.Please reload this page.
fabpot approved these changesApr 3, 2019
Member
fabpot commentedApr 3, 2019
Thank you@nicoweb. |
fabpot added a commit that referenced this pull requestApr 3, 2019
This PR was merged into the 4.3-dev branch.Discussion----------[RouterDebugCommand] add link to Controllers| Q | A| ------------- | ---| Branch? | master for features| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Adds a link to the controller method on your IDE from dev's terminal:<img width="734" alt="pr-debug-router" src="https://user-images.githubusercontent.com/29813575/54141007-1f3bc400-4425-11e9-82d0-1b37498d4953.png">Configuration in your `services.yaml`:```yamlparameters: debug.file_link_format: phpstorm://open?file=%%f&line=%%l```Commits-------e9fca21 [RouterDebugCommand] add link to Controllers
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a link to the controller method on your IDE from dev's terminal:
Configuration in your
services.yaml: