Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Fix perf when using RedisCluster by reducing roundtrips to the servers#30518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromandrerom:redis_cluster_versioning_fixesMar 13, 2019
Merged
[Cache] Fix perf when using RedisCluster by reducing roundtrips to the servers#30518
nicolas-grekas merged 1 commit intosymfony:3.4fromandrerom:redis_cluster_versioning_fixesMar 13, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…e serversThis is slimmed down version of:symfony#28269 _(many of the fixes here are already part of 3.4)_Adds:- Test coverage for Predis with RedisCluster- Removes usage of key versioning when on RedisCluster, besides performance aspect of that simplify / aligning clear() handling across cases
2d75184 todacf179Comparenicolas-grekas approved these changesMar 12, 2019
Member
nicolas-grekas commentedMar 13, 2019
Thank you@andrerom. |
nicolas-grekas added a commit that referenced this pull requestMar 13, 2019
…trips to the servers (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[Cache] Fix perf when using RedisCluster by reducing roundtrips to the servers| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MITThis is slimmed down version of:#28269 _(many of the fixes there are already part of 3.4)_Does:- Adds test coverage for Predis with RedisCluster- Removes usage of key versioning when on RedisCluster, besides performance aspect of that it simplifies / aligning clear() handling across all clients- reuse doDelete() from clear to make sure we call singular del calls when in predis clusterCommits-------dacf179 [Cache] Fix perf when using RedisCluster by reducing roundtrips to the servers
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is slimmed down version of:#28269(many of the fixes there are already part of 3.4)
Does: