Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] replace "nullable" env processor by improving the "default" one#30504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
22823d2 tod6a1871Comparebpolaszek commentedMar 10, 2019
But it was my 1st PR! 😥 (French contributors will remind "mais t'avais dit qu'on ferait des knacki!") More seriously, that's a good idea 🙂 thank you@nicolas-grekas ! |
ogizanagi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great. I like this one much more :)
d6a1871 toc50aad2Comparenicolas-grekas commentedMar 10, 2019
@jderusse@bpolaszek would you mind sending a doc PR please? (see#10722) |
jderusse commentedMar 10, 2019
done insymfony/symfony-docs#11127 |
fabpot commentedMar 10, 2019
Thank you@nicolas-grekas. |
… "default" one (nicolas-grekas)This PR was merged into the 4.3-dev branch.Discussion----------[DI] replace "nullable" env processor by improving the "default" one| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Neither `nullable` nor `default` are released yet.I propose to replace the `nullable` processor (see#29767) with an improved `default` one (from#28976).`%env(default::FOO)%` now defaults to `null` when the env var doesn't exist or compares to false".ping@jderusse@bpolaszekCommits-------c50aad2 [DI] replace "nullable" env processor by improving the "default" one
…sse)This PR was merged into the master branch.Discussion----------Document Default env processor with null fallbackDocument the fallback to `null`PR:symfony/symfony#30504Commits-------309bd58 Document Default env processor with null fallback
Neither
nullablenordefaultare released yet.I propose to replace the
nullableprocessor (see#29767) with an improveddefaultone (from#28976).%env(default::FOO)%now defaults tonullwhen the env var doesn't exist or compares to false".ping@jderusse@bpolaszek