Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Create a hyperlink to interfaces/classes that can be autowired#30469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromSerkanYildiz:add-hyperlinks-for-autowirable-services
Mar 15, 2019
Merged

Create a hyperlink to interfaces/classes that can be autowired#30469

nicolas-grekas merged 1 commit intosymfony:masterfromSerkanYildiz:add-hyperlinks-for-autowirable-services
Mar 15, 2019

Conversation

@SerkanYildiz
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
LicenseMIT

Added hyperlink to definition of interfaces/classes that can be used for autowiring.
But I need help with:

  • the aliases are becoming hyperlinks too, but shouldn't.
    It's outputting<fg=yellow;href=phpstorm://open?file=filepath&line=17>Symfony\Contracts\Translation\TranslatorInterface</> <fg=cyan>(translator.default)</>

  • it currently works with phpstorm because it's hardcoded but it should work with framework.ide option, but don't know what the best approach is to support that config option.

vesquen reacted with heart emoji
@SerkanYildizSerkanYildiz changed the titleCreate a hyperlink for interfaces/classes that can be autowiredCreate a hyperlink to interfaces/classes that can be autowiredMar 7, 2019
@nicolas-grekasnicolas-grekas added this to thenext milestoneMar 7, 2019
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you, I was hoping PRs on the topics, you're one of the first! There are many more places like this where linking could be nice :)

@SerkanYildiz
Copy link
ContributorAuthor

SerkanYildiz commentedMar 7, 2019•
edited
Loading

Hi@nicolas-grekas,

Thanks for your review. I still have the problem with that the service alias is getting linked too. Do you know where I should look at?

edit: might be a problem of zsh (I think it assumes that cache.app is a url)

@SerkanYildiz
Copy link
ContributorAuthor

Status: Needs Review

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice feature! Thank you Serkan.

@nicolas-grekas
Copy link
Member

Thank you@SerkanYildiz.

@nicolas-grekasnicolas-grekas merged commita3dfcee intosymfony:masterMar 15, 2019
nicolas-grekas added a commit that referenced this pull requestMar 15, 2019
…utowired (SerkanYildiz)This PR was squashed before being merged into the 4.3-dev branch (closes#30469).Discussion----------Create a hyperlink to interfaces/classes that can be autowired| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MITAdded hyperlink to definition of interfaces/classes that can be used for autowiring.But I need help with:- the aliases are becoming hyperlinks too, but shouldn't.It's outputting `<fg=yellow;href=phpstorm://open?file=filepath&line=17>Symfony\Contracts\Translation\TranslatorInterface</> <fg=cyan>(translator.default)</>`- it currently works with phpstorm because it's hardcoded but it should work with framework.ide option, but don't know what the best approach is to support that config option.Commits-------a3dfcee Create a hyperlink to interfaces/classes that can be autowired
@SerkanYildizSerkanYildiz deleted the add-hyperlinks-for-autowirable-services branchMarch 15, 2019 13:26
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@OskarStarkOskarStarkOskarStark requested changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@SerkanYildiz@nicolas-grekas@javiereguiluz@stof@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp