Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] Added support for many inital places#30468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lyrixx merged 1 commit intosymfony:masterfromlyrixx:w-mutli-init-places
Mar 22, 2019

Conversation

@lyrixx
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#30080
LicenseMIT
Doc PR

Korbeil, sfavot, and TheCrealm reacted with thumbs up emojiKorbeil and TheCrealm reacted with hooray emoji
Copy link
Contributor

@KorbeilKorbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for this PR, this will help us improve how we use workflow 😄

Quick notice, I did not see tests with multiple initial places, I think it should be better to add atleast one.

Also, is there a reason you don't throw an Exception when we have multiple initial places withsingle_state marking store ?

@lyrixxlyrixx changed the titleAdded support for many inital places[Workflow] Added support for many inital placesMar 12, 2019
@lyrixx
Copy link
MemberAuthor

Also, is there a reason you don't throw an Exception when we have multiple initial places withsingle_state marking store ?

I will do that once#29457 is merged. It will be much more easier

@lyrixx
Copy link
MemberAuthor

Here we Go. I updated validators and added test 👍

Copy link
Contributor

@KorbeilKorbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks ! 👍

@lyrixxlyrixxforce-pushed thew-mutli-init-places branch 2 times, most recently from9c10c81 to56c6090CompareMarch 13, 2019 16:23
@lyrixxlyrixxforce-pushed thew-mutli-init-places branch 2 times, most recently froma3ca1b6 to66119d5CompareMarch 20, 2019 19:14
@lyrixxlyrixx merged commit1af1bf2 intosymfony:masterMar 22, 2019
lyrixx added a commit that referenced this pull requestMar 22, 2019
This PR was merged into the 4.3-dev branch.Discussion----------[Workflow] Added support for many inital places| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#30080| License       | MIT| Doc PR        |Commits-------1af1bf2 Added support for many inital places
@lyrixxlyrixx deleted the w-mutli-init-places branchMarch 22, 2019 14:52
lyrixx added a commit to lyrixx/symfony that referenced this pull requestApr 6, 2019
I introduced a BC break insymfony#30468 and this PR fix it.With the full stack framework, when one does not configure theinitial_place(s) the DIC set `[]` for the initial values.So it removes the initials values guessed in `Definition::addPlace()`
lyrixx added a commit to lyrixx/symfony that referenced this pull requestApr 6, 2019
I introduced a BC break insymfony#30468 and this PR fix it.With the full stack framework, when one does not configure theinitial_place(s) the DIC set `[]` for the initial values.So it removes the initials values guessed in `Definition::addPlace()`
fabpot added a commit that referenced this pull requestApr 6, 2019
…red (lyrixx)This PR was merged into the 4.3-dev branch.Discussion----------[Workflow] Fixed initial places when no places are configured| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? || Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |EUFOSSAI introduced a BC break in#30468 and this PR fix it.With the full stack framework, when one does not configure theinitial_place(s) the DIC set `[]` for the initial values.So it removes the initials values guessed in `Definition::addPlace()`Commits-------76fd9c3 [Workflow] Fixed initial places when no places are configured
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
lyrixx added a commit to lyrixx/symfony that referenced this pull requestJun 28, 2019
lyrixx added a commit to lyrixx/symfony that referenced this pull requestJun 28, 2019
lyrixx added a commit to lyrixx/symfony that referenced this pull requestJun 28, 2019
lyrixx added a commit to lyrixx/symfony that referenced this pull requestJun 28, 2019
lyrixx added a commit to lyrixx/symfony that referenced this pull requestJun 28, 2019
lyrixx added a commit that referenced this pull requestJun 28, 2019
…() (lyrixx)This PR was merged into the 4.3 branch.Discussion----------[Workflow] Deprecated DefinitionBuilder::setInitialPlace()Added missing part of#30468| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Commits-------4d002e8 [Workflow] Deprecated DefinitionBuilder::setInitialPlace()
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

+1 more reviewer

@KorbeilKorbeilKorbeil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@lyrixx@nicolas-grekas@Korbeil@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp