Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge] Fix DebugCommand when chain loader is involved#30440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
yceruto commentedMar 4, 2019
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
fabpot approved these changesMar 20, 2019
Member
fabpot commentedMar 20, 2019
Thank you@yceruto. |
fabpot added a commit that referenced this pull requestMar 20, 2019
…d (yceruto)This PR was merged into the 4.2 branch.Discussion----------[TwigBridge] Fix DebugCommand when chain loader is involved| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#30426| License | MITBetter diff:https://github.com/symfony/symfony/pull/30440/files?utf8=%E2%9C%93&diff=unified&w=1Commits-------f647b4a Fix DebugCommand when chain loader is involved
Uh oh!
There was an error while loading.Please reload this page.
fabpot added a commit that referenced this pull requestMar 20, 2019
… same namespace (yceruto)This PR was merged into the 4.2 branch.Discussion----------Fix case when multiple loaders are providing paths for the same namespace| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MITFixes@stof#30440 (comment)Let me know if a test case is necessary for this.Cheers!Commits-------393d728 Fix case when multiple loaders are providing paths for the same namespace
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Better diff:https://github.com/symfony/symfony/pull/30440/files?utf8=%E2%9C%93&diff=unified&w=1