Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Allow to disable and customize PercentType symbol#30433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Form] Allow to disable and customize PercentType symbol#30433
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedMar 4, 2019
@OskarStark Do you think it's possible to keep ownership of the commit to the original author? |
OskarStark commentedMar 4, 2019
I am not sure, I talked to@xabbuh and we decided to create a new PR, the repository of the original author is deleted and I don't have some access to get the commits somehow. |
fabpot commentedMar 4, 2019
ok, fair enough, can you fixed fabbot issues (mainly array() -> [])? |
OskarStark commentedMar 4, 2019
sure thing, will have a look
still onto it and try to understand whats wrong here 👍 |
OskarStark commentedMar 4, 2019
normal anddeps=low build failures are not related to this change. deps=high needs to be skipped |
OskarStark commentedMar 4, 2019
Looks like the tests are 💚 |
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/percent_widget.html.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
OskarStark commentedMar 5, 2019
@fabpot I applied your comments |
src/Symfony/Bridge/Twig/Tests/Extension/AbstractBootstrap3LayoutTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/percent_widget.html.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/percent_widget.html.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
fabpot commentedMar 5, 2019
Thank you@OskarStark. |
…ol (Ken Stanley, OskarStark)This PR was merged into the 4.3-dev branch.Discussion----------[Form] Allow to disable and customize PercentType symbol| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#28796 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR |symfony/symfony-docs#11078<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->## `PercentType` `symbol` optionAs of this writing, Symfony will forcibly append a percentage sign (`%`) to all input fields that are of the PercentType form type. This PR will introduce a boolean flag called `symbol` that, when `false`, will not display the percentage sign. Each of the default layouts that define percent_widget will respect this option. You could also use a customised string as value for `symbol` option.By default, this new option will be set to `true` so that it maintains backward compatibility. The unit tests have been updated where appropriate, and a new unit test has been added (as appropriate).Commits-------53c5f41 [Form] Allow to disable and customize PercentType symbol9aeaea0 Add ‘symbol’ option to PercentType
… (OskarStark)This PR was merged into the master branch.Discussion----------Docs for PercentType disable/customize percent characterDocs forsymfony/symfony#30433Closes#10464Commits-------16b2e4b Docs for PercentType disable/customize percent character
Uh oh!
There was an error while loading.Please reload this page.
PercentTypesymboloptionAs of this writing, Symfony will forcibly append a percentage sign (
%) to all input fields that are of the PercentType form type. This PR will introduce a boolean flag calledsymbolthat, whenfalse, will not display the percentage sign. Each of the default layouts that define percent_widget will respect this option. You could also use a customised string as value forsymboloption.By default, this new option will be set to
trueso that it maintains backward compatibility. The unit tests have been updated where appropriate, and a new unit test has been added (as appropriate).