Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] Allow to disable and customize PercentType symbol#30433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 2 commits intosymfony:masterfromOskarStark:allow-toggling-and-customising-percentage-symbol
Mar 5, 2019
Merged

[Form] Allow to disable and customize PercentType symbol#30433

fabpot merged 2 commits intosymfony:masterfromOskarStark:allow-toggling-and-customising-percentage-symbol
Mar 5, 2019

Conversation

@OskarStark
Copy link
Contributor

@OskarStarkOskarStark commentedMar 4, 2019
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28796
LicenseMIT
Doc PRsymfony/symfony-docs#11078

PercentTypesymbol option

As of this writing, Symfony will forcibly append a percentage sign (%) to all input fields that are of the PercentType form type. This PR will introduce a boolean flag calledsymbol that, whenfalse, will not display the percentage sign. Each of the default layouts that define percent_widget will respect this option. You could also use a customised string as value forsymbol option.

By default, this new option will be set totrue so that it maintains backward compatibility. The unit tests have been updated where appropriate, and a new unit test has been added (as appropriate).

@fabpot
Copy link
Member

@OskarStark Do you think it's possible to keep ownership of the commit to the original author?

@OskarStark
Copy link
ContributorAuthor

I am not sure, I talked to@xabbuh and we decided to create a new PR, the repository of the original author is deleted and I don't have some access to get the commits somehow.

@fabpot
Copy link
Member

ok, fair enough, can you fixed fabbot issues (mainly array() -> [])?
Tests look broken as well for the added feature.

@OskarStark
Copy link
ContributorAuthor

can you fixed fabbot issues (mainly array() -> [])?

sure thing, will have a look

Tests look broken as well for the added feature.

still onto it and try to understand whats wrong here 👍

@OskarStark
Copy link
ContributorAuthor

normal anddeps=low build failures are not related to this change.

deps=high needs to be skipped

@OskarStark
Copy link
ContributorAuthor

Looks like the tests are 💚

@OskarStark
Copy link
ContributorAuthor

@fabpot I applied your comments

@OskarStarkOskarStark changed the title[Form] Allow to disable and customise PercentType symbol[Form] Allow to disable and customize PercentType symbolMar 5, 2019
@fabpot
Copy link
Member

Thank you@OskarStark.

OskarStark reacted with thumbs up emoji

@fabpotfabpot merged commit53c5f41 intosymfony:masterMar 5, 2019
fabpot added a commit that referenced this pull requestMar 5, 2019
…ol (Ken Stanley, OskarStark)This PR was merged into the 4.3-dev branch.Discussion----------[Form] Allow to disable and customize PercentType symbol| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#28796   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        |symfony/symfony-docs#11078<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->## `PercentType` `symbol` optionAs of this writing, Symfony will forcibly append a percentage sign (`%`) to all input fields that are of the PercentType form type. This PR will introduce a boolean flag called `symbol` that, when `false`, will not display the percentage sign. Each of the default layouts that define percent_widget will respect this option. You could also use a customised string as value for `symbol` option.By default, this new option will be set to `true` so that it maintains backward compatibility. The unit tests have been updated where appropriate, and a new unit test has been added (as appropriate).Commits-------53c5f41 [Form] Allow to disable and customize PercentType symbol9aeaea0 Add ‘symbol’ option to PercentType
@OskarStarkOskarStark deleted the allow-toggling-and-customising-percentage-symbol branchMarch 5, 2019 10:31
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestMar 27, 2019
… (OskarStark)This PR was merged into the master branch.Discussion----------Docs for PercentType disable/customize percent characterDocs forsymfony/symfony#30433Closes#10464Commits-------16b2e4b Docs for PercentType disable/customize percent character
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@OskarStark@fabpot@xabbuh@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp