Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Autoconfig: don't automatically tag decorators#30417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@dunglas
Copy link
Member

QA
Branch?4.1
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30391
LicenseMIT
Doc PRn/a

bendavies reacted with thumbs up emoji
@bendavies
Copy link
Contributor

fixes the linked issue

dunglas reacted with thumbs up emoji

@fabpot
Copy link
Member

will be merged in 4.2.

@fabpotfabpot changed the base branch from4.1 to4.2March 4, 2019 08:50
@fabpotfabpotforce-pushed theno-tags-decorator-autoconfigure branch from41f877a to05ecf82CompareMarch 4, 2019 08:50
@fabpot
Copy link
Member

Thank you@dunglas.

@fabpotfabpot merged commit05ecf82 intosymfony:4.2Mar 4, 2019
fabpot added a commit that referenced this pull requestMar 4, 2019
This PR was submitted for the 4.1 branch but it was merged into the 4.2 branch instead (closes#30417).Discussion----------Autoconfig: don't automatically tag decorators| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | yes| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#30391   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | n/aCommits-------05ecf82 Autoconfig: don't automatically tag decorators
@fabpotfabpot mentioned this pull requestApr 2, 2019
fabpot added a commit that referenced this pull requestFeb 4, 2022
…ecorators (LANGERGabrielle)This PR was merged into the 5.4 branch.Discussion----------[DependencyInjection] Fix AsEventListener not working on decorators| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |When using the `AsEventListener` on a decorator, it is ignored instead of registering the decorator as an event listener. This is because autoconfigured tags are not applied to decorators since#30417.`EventSubscriberInterface` works as expected since#38999, when the `kernel.event_subscriber'` tag was added to a list of "behavior describing tags" which can be autoconfigured onto decorators.This PR adds `kernel.event_listener` to this default list of tags, making `AsEventListener` work as expected on decorators.Commits-------5fbb217 Added `kernel.event_listener` to the default list of behavior describing tags, fixing AsEventListener attribute not working on decorators.
nicolas-grekas added a commit that referenced this pull requestJul 7, 2023
…l decorator (HypeMC)This PR was merged into the 5.4 branch.Discussion----------[DependencyInjection] Don't ignore attributes on the actual decorator| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#49931| License       | MIT| Doc PR        | -An attempt tofix#49931 without reintroducing the problem reported in#30391 and fixed by#30417. The idea here is that if the attribute is declared on the decorator itself, it shouldn't be ignored as it was explicitly added.Commits-------fdd2ec2 [DependencyInjection] Don't ignore attributes on the actual decorator
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dunglas@bendavies@fabpot@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp