Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle][Routing] allow boolean container parameters for routes#30379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromdmaicher:issue-30366
Mar 4, 2019

Conversation

@dmaicher
Copy link
Contributor

@dmaicherdmaicher commentedFeb 25, 2019•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30366
LicenseMIT
Doc PRsymfony/symfony-docs#11059

Thisfixes#30366 and adds support for boolean container parameters in route conditions, defaults etc.

quazardous, OskarStark, delirehberi, and tristanbes reacted with thumbs up emoji
@OskarStark
Copy link
Contributor

I like it, can you please send a doc PR? 🙏

@dmaicher
Copy link
ContributorAuthor

I like it, can you please send a doc PR? pray

sure 👍 wondering what exactly to add there 😄

https://symfony.com/doc/master/routing/service_container_parameters.html

Should it be one of those "NEW... since Symfony 4.3 you can also use boolean parameters" box?

@nicolas-grekas
Copy link
Member

Not sure myself how/if this should be documented :)

@OskarStark
Copy link
Contributor

Yes you should add a.. versionadded:: 4.3 directive 👍

@fabpot
Copy link
Member

Thank you@dmaicher.

@fabpotfabpot merged commit21f4e38 intosymfony:masterMar 4, 2019
fabpot added a commit that referenced this pull requestMar 4, 2019
…ameters for routes (dmaicher)This PR was merged into the 4.3-dev branch.Discussion----------[FrameworkBundle][Routing] allow boolean container parameters for routes| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30366| License       | MIT| Doc PR        |symfony/symfony-docs#11059Thisfixes#30366 and adds support for boolean container parameters in route conditions, defaults etc.Commits-------21f4e38 [FrameworkBundle][Routing] allow boolean container parameters for routes
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestMar 15, 2019
…eters for routes (dmaicher)This PR was merged into the master branch.Discussion----------[FrameworkBundle][Routing] allow boolean container parameters for routesSeesymfony/symfony#30379Commits-------d89122c Update service_container_parameters.rst
@fabpotfabpot mentioned this pull requestMay 9, 2019
@dmaicherdmaicher deleted the issue-30366 branchJanuary 29, 2021 21:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support boolean parameters in Route condition

5 participants

@dmaicher@OskarStark@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp