Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Fixed duplicate UUID#30324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromralfkuehnel:issue-30285
Feb 21, 2019
Merged

[Validator] Fixed duplicate UUID#30324

fabpot merged 1 commit intosymfony:3.4fromralfkuehnel:issue-30285
Feb 21, 2019

Conversation

@ralfkuehnel
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30285
LicenseMIT
Doc PRN/A

Fixes theTOO_HIGH_ERROR constant had the same value in two different constraints:LessThan andLessThanOrEqual.

@fabpot
Copy link
Member

Thank you@ralfkuehnel.

@fabpotfabpot merged commit0bd5dd8 intosymfony:3.4Feb 21, 2019
fabpot added a commit that referenced this pull requestFeb 21, 2019
This PR was merged into the 3.4 branch.Discussion----------[Validator] Fixed duplicate UUID| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30285| License       | MIT| Doc PR        | N/AFixes the `TOO_HIGH_ERROR` constant had the same value in two different constraints: `LessThan` and `LessThanOrEqual`.Commits-------0bd5dd8 [Validator] Fixed duplicate UUID
@javiereguiluz
Copy link
Member

Thanks Ralf! If you did this change cloning the repo on your local machine and working with Git in your terminal, I'd love to know if you had any problem. Also, if you followed the Symfony contribution guide, I'd like to know if there was any confusing instruction on it. If you have any comments, you can reach me via email or Slack. Thanks again for your contribution!

romainnorberg reacted with thumbs up emoji

@ralfkuehnel
Copy link
ContributorAuthor

ralfkuehnel commentedFeb 21, 2019•
edited
Loading

@javiereguiluz I have followed the Symfony contribution guide to make the change on my local machine! It was straight forward, no problems! Already looking forward to make my next contribution! :)

javiereguiluz and xabbuh reacted with thumbs up emoji

This was referencedMar 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ralfkuehnel@fabpot@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp