Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] do not validate non-submitted form fields in PATCH requests#30265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
930785e tobda4eb5Compare
HeahDude left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, this is so nice to approve such a PR :). Thank you so much!
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
uninformed vote, but still happy and confident you solved that many (old) issues :)
…requests (xabbuh)This PR was merged into the 3.4 branch.Discussion----------[Form] do not validate non-submitted form fields in PATCH requests| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#11493,#19788,#20805,#24453,#30011| License | MIT| Doc PR |When a form field is not embedded as part of a HTTP PATCH requests, itsvalidation constraints configured through the `constraints` option mustnot be evaluated. The fix from#10567 achieved this by not mapping theirviolations to the underlying form field. This however also means thatconstraint violations caused by validating the whole underlying dataobject will never cause the form to be invalid. This breaks use caseswhere some constraints may, for example, depend on the value of otherproperties that were changed by the submitted data.Commits-------a60d802 do not validate non-submitted form fields in PATCH requests
ogizanagi commentedFeb 28, 2019
Confirming this is solving the issue, as I've just hit it and tried this patch 😉 |
xabbuh commentedFeb 28, 2019
Thanks for the confirmation@ogizanagi! |
Uh oh!
There was an error while loading.Please reload this page.
When a form field is not embedded as part of a HTTP PATCH requests, its
validation constraints configured through the
constraintsoption mustnot be evaluated. The fix from#10567 achieved this by not mapping their
violations to the underlying form field. This however also means that
constraint violations caused by validating the whole underlying data
object will never cause the form to be invalid. This breaks use cases
where some constraints may, for example, depend on the value of other
properties that were changed by the submitted data.