Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Routing] deprecate some router options#30249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromTobion:deprecate-routing-options
Feb 21, 2019

Conversation

@Tobion
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#28865 (comment)
LicenseMIT
Doc PRsymfony/symfony-docs#...

@TobionTobionforce-pushed thedeprecate-routing-options branch from9ad7aaf to763738cCompareFebruary 14, 2019 23:32
@Tobion
Copy link
ContributorAuthor

For some reason the non-insulted functional tests are failing.

sstok reacted with laugh emoji

@TobionTobionforce-pushed thedeprecate-routing-options branch from763738c toa4e592fCompareFebruary 15, 2019 14:12
@TobionTobionforce-pushed thedeprecate-routing-options branch froma4e592f tobf4cd61CompareFebruary 15, 2019 14:28
@nicolas-grekasnicolas-grekas added this to thenext milestoneFeb 16, 2019
@xabbuh
Copy link
Member

we should document this inUPGRADE-4.3.md andUPGRADE-5.0.md too though

@fabpot
Copy link
Member

Thank you@Tobion.

@fabpotfabpot merged commitbf4cd61 intosymfony:masterFeb 21, 2019
fabpot added a commit that referenced this pull requestFeb 21, 2019
This PR was merged into the 4.3-dev branch.Discussion----------[Routing] deprecate some router options| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | yes <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#28865 (comment)| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features --><!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Commits-------bf4cd61 [Routing] deprecate some router options
@TobionTobion deleted the deprecate-routing-options branchFebruary 22, 2019 16:05
fabpot added a commit that referenced this pull requestMar 3, 2019
This PR was merged into the 4.3-dev branch.Discussion----------add deprecated router options to upgrade files| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30249 (comment)| License       | MIT| Doc PR        |Commits-------c3da27a add deprecated router options to upgrade files
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
nicolas-grekas added a commit that referenced this pull requestJun 5, 2019
This PR was merged into the 5.0-dev branch.Discussion----------[Routing] remove deprecations| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | yes     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets || License       | MIT| Doc PR        |Ref.#30249,#30286,#24894Commits-------5beb5f8 [Routing] remove deprecations
@ViPErCZ
Copy link

How prefix UrlGenerator and UrlMatcher in cache directory?

@ViPErCZ
Copy link

PS: cache_class_prefix is not used now ?

@flack
Copy link
Contributor

Hi!

Is there any explanation why these options were being deprecated/removed? I use sf routing standalone in a framework where you have separate application modules (each with its own set of routes) and a prefix that is dynamically changeable (well, at least that's the simplified way to put it).

The way I implement this is to have one router instance per application module instantiated with the non-prefixed route collection (and before callingmatch I set the prefix withgetContext()->setBaseUrl()). The ability to specifymatcher_cache_class andgenerator_cache_class allowed me to cache each of the router instances separately, but with 5.0, I'm now forced to disable caching, which ofc sucks for performance.

Is there any way around this?

(pls don't say "use Dynamic Router from Symfony CMF". For one thing, it's not compatible with 5.0 yet, also I would have to write a ton of integration code, and by looking at the repo, it seems to be in deep maintenance mode, and I don't want to add a dependency that could get abandoned any time now)

@flack
Copy link
Contributor

ok, found a workaround in the linked ticket: You have to set a differentcache_dir for each router instance now. Would have been nice if this would have been mentioned in UPGRADING.md though

@xabbuh
Copy link
Member

@flack Would you like to send a PR with the upgrade instruction improvements that you have in mind?

@flack
Copy link
Contributor

@xabbuh done in#35297

flack added a commit to flack/symfony that referenced this pull requestJan 10, 2020
fabpot added a commit that referenced this pull requestJan 11, 2020
…ions (flack)This PR was merged into the 4.4 branch.Discussion----------Improve upgrading instructions for deprecated router optionsSee#30249 (comment)| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |#30249| License       | MIT| Doc PR        |Commits-------2cc7083 Improve upgrading instructions for deprecated router options
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@vudaltsovvudaltsovvudaltsov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

10 participants

@Tobion@xabbuh@fabpot@ViPErCZ@flack@nicolas-grekas@stof@OskarStark@vudaltsov@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp