Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix lost namespace in eval#30245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.2fromfizzka:patch-1
Feb 16, 2019
Merged

fix lost namespace in eval#30245

fabpot merged 1 commit intosymfony:4.2fromfizzka:patch-1
Feb 16, 2019

Conversation

@fizzka
Copy link
Contributor

@fizzkafizzka commentedFeb 14, 2019
edited
Loading

Bugfix:
phpunit8 tearDown() declaration

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

oups :)

trait KernelShutdownOnTearDownTrait
{
/**
* @return void

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

please keep the annotation

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

reverted!

@fabpot
Copy link
Member

Thank you@fizzka.

@fabpotfabpot merged commit8743a1a intosymfony:4.2Feb 16, 2019
fabpot added a commit that referenced this pull requestFeb 16, 2019
This PR was squashed before being merged into the 4.2 branch (closes#30245).Discussion----------fix lost namespace in evalBugfix:phpunit8 tearDown() declarationCommits-------8743a1a fix lost namespace in eval
nicolas-grekas pushed a commit that referenced this pull requestFeb 16, 2019
This PR was squashed before being merged into the 4.2 branch (closes#30245).Discussion----------fix lost namespace in evalBugfix:phpunit8 tearDown() declarationCommits-------8743a1a fix lost namespace in eval
@nicolas-grekas
Copy link
Member

added to 3.4 inda325fc

fabpot added a commit that referenced this pull requestFeb 18, 2019
* 3.4:  [TwigBridge] Fix test  Remove unnecessary ProgressBar stdout writes (fixes flickering)  [Validator] improve translations for albanian ("sq") locale  [VarDumper] fix serializing Stub instances  Don't resolve the Deprecation error handler mode until a deprecation is triggered  bug#30245 fix lost namespace in eval (fizzka)  [Twig] removed usage of non-namespaced classes  added missing dot  Update validators.lt.xlf#30172 Add the missing validation translations for the Luxembourgish …  [Debug][ErrorHandler] Preserve next error handler
@xabbuhxabbuh added this to the3.4 milestoneFeb 18, 2019
nicolas-grekas added a commit that referenced this pull requestFeb 19, 2019
* 4.2:  [Console] Fix command testing with missing inputs  [Validator] Sync no/nb translation files  [Translation] Added a script to display the status of translations  [Validator] Added missing translations for Norwegian (\"no\") locale#30179  [Security\Guard] bump lowest version of security-core  [TwigBridge] Fix test  Remove unnecessary ProgressBar stdout writes (fixes flickering)  [Validator] improve translations for albanian ("sq") locale  [VarDumper] fix serializing Stub instances  [Validator] Added missing use statement for UnexpectedTypeException  Don't resolve the Deprecation error handler mode until a deprecation is triggered  bug#30245 fix lost namespace in eval (fizzka)  fix lost namespace in eval  [Twig] removed usage of non-namespaced classes  added missing dot  Update validators.lt.xlf#30172 Add the missing validation translations for the Luxembourgish …  [Debug][ErrorHandler] Preserve next error handler
@fabpotfabpot mentioned this pull requestMar 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@fizzka@fabpot@nicolas-grekas@Tobion@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp