Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

use PropertyAccessorInterface instead of PropertyAccessor#30136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromnick-zh:master
Feb 12, 2019
Merged

use PropertyAccessorInterface instead of PropertyAccessor#30136

fabpot merged 1 commit intosymfony:3.4fromnick-zh:master
Feb 12, 2019

Conversation

@nick-zh
Copy link
Contributor

@nick-zhnick-zh commentedFeb 11, 2019•
edited
Loading

[Validator] [Constraints] use PropertyAccessorInterface instead of PropertyAccessor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30133 (partially)
LicenseMIT
Doc PRnone

@chalasrchalasr added this to thenext milestoneFeb 11, 2019
Copy link
Contributor

@ogizanagiogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch. Should we backport to 3.4 actually?

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like something for 3.4 indeed.

@nick-zh
Copy link
ContributorAuthor

I don't know how you guys usually handle this, but since the change is very small and probably has no negative impact, it could make sense. Let me know if i should open PR's for other branches as well.

@fabpotfabpot changed the base branch frommaster to3.4February 12, 2019 07:15
@fabpot
Copy link
Member

Thank you@nick-zh.

nick-zh reacted with thumbs up emoji

@fabpotfabpot merged commit3e3ca9d intosymfony:3.4Feb 12, 2019
fabpot added a commit that referenced this pull requestFeb 12, 2019
…(nick-zh)This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes#30136).Discussion----------use PropertyAccessorInterface instead of PropertyAccessor[Validator] [Constraints] use PropertyAccessorInterface instead of PropertyAccessor| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30133 (partially)| License       | MIT| Doc PR        | noneCommits-------3e3ca9d use PropertyAccessorInterface instead of PropertyAccessor
@chalasrchalasr modified the milestones:next,3.4Feb 12, 2019
This was referencedMar 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

+2 more reviewers

@ogizanagiogizanagiogizanagi approved these changes

@vudaltsovvudaltsovvudaltsov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

8 participants

@nick-zh@fabpot@OskarStark@xabbuh@ogizanagi@vudaltsov@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp