Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix KernelTestCase compatibility for PhpUnit 8 (bis)#30124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
OskarStark approved these changesFeb 9, 2019
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
MemberAuthor
nicolas-grekas commentedFeb 10, 2019
Comments addressed, thanks for the review. |
vudaltsov approved these changesFeb 10, 2019
Taluu approved these changesFeb 10, 2019
Uh oh!
There was an error while loading.Please reload this page.
xabbuh approved these changesFeb 10, 2019
DanielBadura approved these changesFeb 11, 2019
ogizanagi approved these changesFeb 12, 2019
fabpot approved these changesFeb 12, 2019
Member
fabpot commentedFeb 12, 2019
Thank you@nicolas-grekas. |
fabpot added a commit that referenced this pull requestFeb 12, 2019
…las-grekas)This PR was squashed before being merged into the 3.4 branch (closes#30124).Discussion----------Fix KernelTestCase compatibility for PhpUnit 8 (bis)| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Follow up of#30084 and@Tobion's comment there.Fabbot failure is a false-positive.Commits-------1077df6 Fix KernelTestCase compatibility for PhpUnit 8 (bis)
This was referencedFeb 24, 2019
nicolas-grekas added a commit that referenced this pull requestFeb 24, 2019
…arDownTrait (skalpa)This PR was merged into the 4.2 branch.Discussion----------[FrameworkBundle] Removed eval() from KernelShutdownOnTearDownTrait| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MITApart from triggering the#30362 bug, the `eval()` block from#30124 also broke my workflow: static code analyzers don't like this, and the trait even crashes PHPStan.It may also bring up other compatibility issues to other people (ie: I know companies that completely disable `eval()` on their servers).As it was only required to keep the trait compatible with PHP 5.x, it is unnecessary on 4.x that requires PHP 7.1+, and this PR removes it on the 4.2 branch.Commits-------324b70a Removed eval() from KernelShutdownOnTearDownTrait
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Follow up of#30084 and@Tobion's comment there.
Fabbot failure is a false-positive.