Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix KernelTestCase compatibility for PhpUnit 8 (bis)#30124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromnicolas-grekas:phpunit8
Feb 12, 2019

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedFeb 9, 2019
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

Follow up of#30084 and@Tobion's comment there.

Fabbot failure is a false-positive.

vudaltsov reacted with hooray emoji
@nicolas-grekas
Copy link
MemberAuthor

Comments addressed, thanks for the review.

vudaltsov reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit1077df6 intosymfony:3.4Feb 12, 2019
fabpot added a commit that referenced this pull requestFeb 12, 2019
…las-grekas)This PR was squashed before being merged into the 3.4 branch (closes#30124).Discussion----------Fix KernelTestCase compatibility for PhpUnit 8 (bis)| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Follow up of#30084 and@Tobion's comment there.Fabbot failure is a false-positive.Commits-------1077df6 Fix KernelTestCase compatibility for PhpUnit 8 (bis)
@nicolas-grekasnicolas-grekas deleted the phpunit8 branchFebruary 17, 2019 14:07
nicolas-grekas added a commit that referenced this pull requestFeb 24, 2019
…arDownTrait (skalpa)This PR was merged into the 4.2 branch.Discussion----------[FrameworkBundle] Removed eval() from KernelShutdownOnTearDownTrait| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MITApart from triggering the#30362 bug, the `eval()` block from#30124 also broke my workflow: static code analyzers don't like this, and the trait even crashes PHPStan.It may also bring up other compatibility issues to other people (ie: I know companies that completely disable `eval()` on their servers).As it was only required to keep the trait compatible with PHP 5.x, it is unnecessary on 4.x that requires PHP 7.1+, and this PR removes it on the 4.2 branch.Commits-------324b70a Removed eval() from KernelShutdownOnTearDownTrait
This was referencedMar 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

+5 more reviewers

@TaluuTaluuTaluu approved these changes

@TobionTobionTobion left review comments

@DanielBaduraDanielBaduraDanielBadura approved these changes

@ogizanagiogizanagiogizanagi approved these changes

@vudaltsovvudaltsovvudaltsov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

10 participants

@nicolas-grekas@fabpot@Taluu@Tobion@OskarStark@xabbuh@DanielBadura@ogizanagi@vudaltsov@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp