Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Filesystem] Fix mirroring a directory into itself or in his child with realpath checks#30116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 2 commits intosymfony:masterfromXuruDragon:fix-filesystem-mirroir
Mar 31, 2019

Conversation

@XuruDragon
Copy link

@XuruDragonXuruDragon commentedFeb 8, 2019•
edited
Loading

QA
Branch?master
Bug fix?yes
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsnone / PR#29857
LicenseMIT
Doc PRn/a

This this the continuity of#29857 by@Fleuv

Fix a bug while trying to mirror a directory into itself or in a child
Adding handle real path checks when mirroring.

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneFeb 8, 2019
@XuruDragonXuruDragonforce-pushed thefix-filesystem-mirroir branch 3 times, most recently from12c07b8 to55e8d21CompareFebruary 8, 2019 15:11
@XuruDragonXuruDragonforce-pushed thefix-filesystem-mirroir branch 3 times, most recently fromfe32a0a to785dc05CompareFebruary 22, 2019 10:33
@XuruDragonXuruDragonforce-pushed thefix-filesystem-mirroir branch 6 times, most recently fromf80d827 toa3efb95CompareMarch 13, 2019 12:10
@XuruDragon
Copy link
Author

XuruDragon commentedMar 13, 2019•
edited
Loading

Add handle for relative paths.

CI build fails not related

@XuruDragonXuruDragonforce-pushed thefix-filesystem-mirroir branch 3 times, most recently frome174f37 to5256eaaCompareMarch 14, 2019 09:22
@XuruDragon
Copy link
Author

XuruDragon commentedMar 14, 2019•
edited
Loading

Added a bypass for symlink mirror tests on windows

CI build fails not related

@fabpot
Copy link
Member

I think this PR does not qualify for being a bug fix but rather as a new feature.

@XuruDragon
Copy link
Author

XuruDragon commentedMar 26, 2019•
edited
Loading

Hi@fabpot , did you really think this PR should be qualify as a new feature ?

Since the behavior ofmirror doesn't match what should be done at the origin (ie not to copy the target directory to the inside of itself).

Indeed, adding absolute path management tomirror might justify qualifying this PR as a new feature, but I think it was just a foregone departure.

@fabpot
Copy link
Member

I still think this is a new feature as the use case itself was not supported at all.

@XuruDragon
Copy link
Author

Ok So I'll rebase this branch on master and change de PR.

@XuruDragonXuruDragon changed the base branch from3.4 tomasterMarch 27, 2019 09:43
@XuruDragonXuruDragon changed the title[Filesystem] Fix trying to mirror a directory into itself or in his child[Filesystem] Fix mirroring a directory into itself or in his child with realpath checksMar 27, 2019
…path name is equal to the target pathAdded a new test what is called testMirrorAvoidCopyingTargetDirectoryIfInSourceDirectoryAdjustments to comply with the Symfony Code Standards
@XuruDragon
Copy link
Author

XuruDragon commentedMar 27, 2019•
edited
Loading

@fabpot as you asked for, I've rebase this PR on master and qualify it as a new feature.

@fabpot
Copy link
Member

Thank you@XuruDragon.

@fabpotfabpot merged commit8011f49 intosymfony:masterMar 31, 2019
fabpot added a commit that referenced this pull requestMar 31, 2019
…in his child with realpath checks (Fleuv, XuruDragon)This PR was merged into the 4.3-dev branch.Discussion----------[Filesystem] Fix mirroring a directory into itself or in his child with realpath checks| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | none / PR#29857| License       | MIT| Doc PR        | n/aThis this the continuity of#29857 by@FleuvFix a bug while trying to mirror a directory into itself or in a childAdding handle real path checks when mirroring.Commits-------8011f49 Handling relative/absolute path59437a4 Skipping iterations in the mirror() method where the iterated file's path name is equal to the target path
@fabpotfabpot mentioned this pull requestMay 9, 2019
@xabbuhxabbuh modified the milestones:3.4,4.3Jun 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@XuruDragon@fabpot@nicolas-grekas@xabbuh@carsonbot@Fleuv
[8]ページ先頭
©2009-2025 Movatter.jp