Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DI] Fix dumping Doctrine-like service graphs (bis)#30096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 2 commits intosymfony:3.4fromnicolas-grekas:di-fix
Jul 29, 2019

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedFeb 6, 2019
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30091,#29637
LicenseMIT
Doc PR-

Dumping the container while accounting for circular references is hard :)

linaori, shyim, and michelmaldonado reacted with hooray emoji
@ro0NL
Copy link
Contributor

the required service reference graph is too crazy

well, thank you :}

conceptually it evolves around using PSR4 prototyped + autowired services, where EM service is bound with a private alias pointing to the actual doctrine EM service. Cool huh 😅

bind:https://github.com/msgphp/msgphp/blob/61f5678b2ab764fb94bd912e6eceab5f3546a8b3/src/UserBundle/Resources/config/doctrine.php#L27
load:https://github.com/msgphp/msgphp/blob/61f5678b2ab764fb94bd912e6eceab5f3546a8b3/src/UserBundle/Resources/config/doctrine.php#L36
alias:https://github.com/msgphp/msgphp/blob/61f5678b2ab764fb94bd912e6eceab5f3546a8b3/src/Domain/Infra/DependencyInjection/BundleHelper.php#L138

Im not sure it's related to the scope where services are registered, in my case from an extension config file, but the alias is registered during bundle booting.

Ill try to replicate it in a minimal DI definition 👍 renamed the repo meanwhile.

Confirmed the patch works. Thanks 💯

@nicolas-grekas
Copy link
MemberAuthor

Status: needs work
I'll try to fix#29637 here also, it's related somehow, and not fixed yet.

liverbool and wiseguy1394 reacted with thumbs up emoji

@nicolas-grekas
Copy link
MemberAuthor

🎉
I've been chasing this for more than one yearalmost day-to-day.
This PR is now green and fixes all the reproducers provided in linked issues + the test cases from@weaverryan (thank you dude!)

dmaicher, NielsJanssen, and deguif reacted with hooray emojidmaicher, OskarStark, B-Galati, and deguif reacted with rocket emoji

@nicolas-grekas
Copy link
MemberAuthor

Thank you@weaverryan.

phansys, ro0NL, and deguif reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commita37f3e0 intosymfony:3.4Jul 29, 2019
nicolas-grekas added a commit that referenced this pull requestJul 29, 2019
…rryan, nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[DI] Fix dumping Doctrine-like service graphs (bis)| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30091,#29637| License       | MIT| Doc PR        | -Dumping the container while accounting for circular references is hard :)Commits-------a37f3e0 [DI] Fix dumping Doctrine-like service graphs (bis)ee49144 Failing test case for complex near-circular situation + lazy
@nicolas-grekasnicolas-grekas deleted the di-fix branchJuly 29, 2019 17:28
This was referencedAug 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@ro0NL@carsonbot@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp