Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Fix dumping Doctrine-like service graphs (bis)#30096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ro0NL commentedFeb 6, 2019
well, thank you :} conceptually it evolves around using PSR4 prototyped + autowired services, where EM service is bound with a private alias pointing to the actual doctrine EM service. Cool huh 😅 bind:https://github.com/msgphp/msgphp/blob/61f5678b2ab764fb94bd912e6eceab5f3546a8b3/src/UserBundle/Resources/config/doctrine.php#L27 Im not sure it's related to the scope where services are registered, in my case from an extension config file, but the alias is registered during bundle booting. Ill try to replicate it in a minimal DI definition 👍 renamed the repo meanwhile. Confirmed the patch works. Thanks 💯 |
nicolas-grekas commentedFeb 6, 2019
Status: needs work |
nicolas-grekas commentedJul 29, 2019
🎉 |
nicolas-grekas commentedJul 29, 2019
Thank you@weaverryan. |
…rryan, nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[DI] Fix dumping Doctrine-like service graphs (bis)| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#30091,#29637| License | MIT| Doc PR | -Dumping the container while accounting for circular references is hard :)Commits-------a37f3e0 [DI] Fix dumping Doctrine-like service graphs (bis)ee49144 Failing test case for complex near-circular situation + lazy
Uh oh!
There was an error while loading.Please reload this page.
Dumping the container while accounting for circular references is hard :)