Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] add $lazyLoad context to the generated code for lazy non-shared service by PhpDumper#30093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.2fromXuruDragon:issue-29930
Feb 8, 2019

Conversation

@XuruDragon
Copy link

QA
Branch?4.1
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29930
LicenseMIT
Doc PRn/a

Fix#29930 by adding $lazyLoad context to the generated code for lazy non-shared service by PhpDumper

@nicolas-grekas
Copy link
Member

Nice. Could you please add a test case with a fixture inPhpDumperTest.php please (see calls toassertStringEqualsFile for inspiration)

@nicolas-grekasnicolas-grekas added this to the4.2 milestoneFeb 6, 2019
@nicolas-grekas
Copy link
Member

Please rebase for 4.2 also as 4.1 is EOLed.

@XuruDragon
Copy link
Author

Nice. Could you please add a test case with a fixture inPhpDumperTest.php please (see calls toassertStringEqualsFile for inspiration)

I'll add it

@XuruDragonXuruDragonforce-pushed theissue-29930 branch 3 times, most recently from37917d9 to5c84edfCompareFebruary 6, 2019 17:36
@XuruDragonXuruDragon changed the base branch from4.1 to4.2February 7, 2019 12:23
@XuruDragonXuruDragonforce-pushed theissue-29930 branch 5 times, most recently from98575cc toa16f92dCompareFebruary 7, 2019 17:27
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

small tweak

@nicolas-grekas
Copy link
Member

Another tweak: in PhpDumper on L690:
$factoryCode = $asFile ? ($definition->isShared() ? "\$this->load('%s.php', false)" : "\$this->factories['%s'](false)") : '$this->%s(false)';

@XuruDragonXuruDragonforce-pushed theissue-29930 branch 2 times, most recently fromc156d03 todf8dd1dCompareFebruary 7, 2019 18:02
…erated factory code for lazy non-shared services| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |symfony#29930| License       | MIT| Doc PR        | n/aFixsymfony#29930  by adding $lazyLoad context to the generated code for lazy non-shared service by PhpDumper
@nicolas-grekas
Copy link
Member

Thank you@XuruDragon.

@nicolas-grekasnicolas-grekas merged commit98d4dfd intosymfony:4.2Feb 8, 2019
nicolas-grekas added a commit that referenced this pull requestFeb 8, 2019
…ed code for lazy non-shared service by PhpDumper (XuruDragon)This PR was merged into the 4.2 branch.Discussion----------[DependencyInjection] add $lazyLoad context to the generated code for lazy non-shared service by PhpDumper| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#29930| License       | MIT| Doc PR        | n/aFix#29930  by adding $lazyLoad context to the generated code for lazy non-shared service by PhpDumperCommits-------98d4dfd [DependencyInjection]fix#29930 add $lazyLoad flag to the generated factory code for lazy non-shared services
@XuruDragonXuruDragon deleted the issue-29930 branchFebruary 8, 2019 12:32
@fabpotfabpot mentioned this pull requestMar 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@XuruDragon@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp