Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] fix PHP 5.3 compat#30087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if (self::MODE_DISABLED !==$mode | ||
| &&self::MODE_WEAK !==$mode | ||
| &&self::MODE_WEAK_VENDORS !==$mode | ||
| if (DeprecationErrorHandler::MODE_DISABLED !==$mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change isn't needed, is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's precisely the line where it fails first :)
https://travis-ci.org/symfony/polyfill/jobs/489417717
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oh PHP 5.3 :o
This PR was merged into the 3.4 branch.Discussion----------[PhpUnitBridge] fix PHP 5.3 compat| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -ONLY FOR 3.4The bridge must remain compatible with PHP 5.3Introduced in33a001e.Commits-------b45cbf6 [PhpUnitBridge] fix PHP 5.3 compat
ONLY FOR 3.4
The bridge must remain compatible with PHP 5.3
Introduced in33a001e.