Isn't it a better solution to check phpunit version here:

and then provide the class with or without final? (if it is even possible like that)

@kunicmarko20 could you please have a look if that would be possible? Can you find any other alternative?

@nicolas-grekas is it maybe possible to remove the TestRunner and move this logic to the Test Command?

@nicolas-grekas@alexander-schranz How can we move forward here?

Will have a look at it, at theEU-FOSSA Hackathon.

Could this help?https://github.com/dg/bypass-finals

@ostrolucky think we don't want to remove all finals.

Maybe there is some suggestion by@sebastianbergmann how we could automatically register the SymfonyListener programmatically now. Did create an issue at the phpunit repositorysebastianbergmann/phpunit#3594

#EU-FOSSA

As I already wrote insebastianbergmann/phpunit#3594 (comment) (why do we have to discuss the same issue in different places?), "automatically registereing" is not possible, and intentionally so: the test runner should not be extended through inheritance but by hooking into certain events. You can find the available hookshere.

What you should do is implement a class that implements one or more of theseHook interfaces. Then have PHPUnit load that class through its configuration file. PHPUnit will then register the hooks.

I can only advise against "hacking around" or "extending" the PHPUnit test runner and then, again and again, update your workarounds when internal implementation details of PHPUnit change. Please do not rely on private implementation details.

In#30085 (review)@nicolas-grekas wrote

we should also report the issue to Sebastian so that he knows some extensibility point is now missing

Yes, please: let me know if you are missing an extension point. While working onhttps://github.com/Roave/no-leaks@Ocramius ran into limitations of the current hooks provided and we plan to work on this in the future.

On a related note, the whole idea of phpunit-bridge is a mystery to me. I do not know what problem(s) you are trying to solve with it. It would be great if somebody could explain that at some point to me. It might be that there are solutions in there for problems that could be solved differently, either inside PHPUnit or in Symfony. I am not conviced that the best medium for this explanation would be a ticket or email. This should, ideally, be a real conversation. Maybe somebody from Symfony can come to a PHPUnit code sprint (there is one in Würzburg this month) or I can come to a Symfony code sprint.

Meeting in person would be great for sure! I'm pretty busy this spring so not sure I can join the next sprint but let's tell each other if we see any opportunity!

The bridge creates an alternative "phpunit binary" that provides some extra features out of the box. With inheritance, it was possible to wire a different behavior by default, but now I'm not sure we can (I didn't have a deeper look). Which features? some extra annotations (@expectedDeprecation,@time-sensitive, etc) and some extra behaviors: the deprecations report that is displayed after running the tests, or a record/replay feature for skipped tests, maybe some more.

The extra features related to annotations work with a line in config files, but the extra behaviors are shipped out of the box when using the bridge.

That's why there is this specific bootstrapping extra layer, which is closed now, withfinal.

Analysed more the current state and I think I could fix it by moving the logic from the TestRunner to the Command.

#EUFOSSA

if it works, perfect :)
wasn'tTestRunnerForV6 reference somewhere?

Can we also remove thesrc/Symfony/Bridge/PhpUnit/TextUI/TestRunner.php file?

@xabbuh It's still used in theCommandForV5, isn't it?

@xabbuh done and move the v5 testrunner logic also to the commandforv5

Thank you@alexander-schranz.