Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] do not overwrite the constraint being evaluated#30062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedFeb 2, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27362 |
| License | MIT |
| Doc PR |
| publicfunctionvalidate($form,Constraint$constraint) | ||
| publicfunctionvalidate($form,Constraint$formConstraint) | ||
| { | ||
| if (!$constraintinstanceof Form) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The$constraint name is also used below when the constraints configured through theconstraints option are iterated, but we do not want to overwrite the reference to the constraint that is validated by this constraints.
HeahDude left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tricky one, thanks!
nicolas-grekas commentedFeb 7, 2019
Thank you@xabbuh. |
…bbuh)This PR was merged into the 3.4 branch.Discussion----------[Form] do not overwrite the constraint being evaluated| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#27362| License | MIT| Doc PR |Commits-------345a632 do not overwrite the constraint being evaluated