Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] fix pruning pdo cache for vendors that throw on execute#30050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.2frombendavies:fix-pdo-cache-prune-table-not-found
Feb 1, 2019
Merged

[Cache] fix pruning pdo cache for vendors that throw on execute#30050

nicolas-grekas merged 1 commit intosymfony:4.2frombendavies:fix-pdo-cache-prune-table-not-found
Feb 1, 2019

Conversation

@bendavies
Copy link
Contributor

QA
Branch?4.2
Bug fix?yes
New feature?no
BC breaks?no >
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

This additionally fixes pruning of the PdoAdapter when the table does not exist.
Similar to#29900#30005 andf419851

@bendaviesbendavies changed the base branch frommaster to4.2January 31, 2019 15:10
@bendaviesbendavies changed the titlefix pruning pdo cache for vendors that throw on execute[Cache] fix pruning pdo cache for vendors that throw on executeJan 31, 2019
@OskarStark
Copy link
Contributor

Shouldnt be a test added/updated?

@bendavies
Copy link
ContributorAuthor

bendavies commentedJan 31, 2019•
edited
Loading

in honestly, i did not check for existing tests as previous fixes for this issue (linked above) added no tests.

@OskarStark
Copy link
Contributor

Maybe this is the reason why this bug occurred afterwards 🙃

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedFeb 1, 2019•
edited
Loading

This is already tested - just not on mysql - and we're not going to add a multi-DB infra for this :)

OskarStark reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@bendavies.

@nicolas-grekasnicolas-grekas merged commit14b9fa5 intosymfony:4.2Feb 1, 2019
nicolas-grekas added a commit that referenced this pull requestFeb 1, 2019
…ecute (bendavies)This PR was merged into the 4.2 branch.Discussion----------[Cache] fix pruning pdo cache for vendors that throw on execute| Q             | A| ------------- | ---| Branch?       | 4.2| Bug fix?      | yes| New feature?  | no| BC breaks?    | no >| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |This additionally fixes pruning of the PdoAdapter when the table does not exist.Similar to#29900#30005 andf419851Commits-------14b9fa5 fix pruning pdo cache for vendors that throw on execute
@fabpotfabpot mentioned this pull requestFeb 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@bendavies@OskarStark@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp