Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] fix some docblocks and type checks#30028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromxabbuh:issue-30018
Jan 30, 2019

Conversation

@xabbuh
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30018
LicenseMIT
Doc PR

@xabbuh
Copy link
MemberAuthor

I have reverted all thestring|int changes. Since theFormConfigBuilder is the only class accepting integers as form names we can probably better deprecate that in Symfony 4.3 and add a type hint in 5.0.

vudaltsov reacted with hooray emoji

@nicolas-grekas
Copy link
Member

Isn't there some BC break potential here?

@xabbuh
Copy link
MemberAuthor

The interface declares that the method must return a string. I wouldn't expect anyone to rely onnull being returned. And the basic use case for this method is the block prefix for the form theming wherenull also doesn't make any sense.

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commitec0c371 intosymfony:3.4Jan 30, 2019
fabpot added a commit that referenced this pull requestJan 30, 2019
This PR was merged into the 3.4 branch.Discussion----------[Form] fix some docblocks and type checks| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#30018| License       | MIT| Doc PR        |Commits-------ec0c371 [Form] fix some docblocks and type checks
@xabbuhxabbuh deleted the issue-30018 branchJanuary 30, 2019 13:06
This was referencedFeb 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoyceruto approved these changes

+1 more reviewer

@vudaltsovvudaltsovvudaltsov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@xabbuh@nicolas-grekas@fabpot@yceruto@vudaltsov@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp