Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in session configuration#30027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromXuruDragon:issue-29830
Feb 8, 2019

Conversation

@XuruDragon
Copy link

@XuruDragonXuruDragon commentedJan 29, 2019•
edited by nicolas-grekas
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#29830
LicenseMIT
Doc PRn/a

this a fix for the issue#29830

After deliberation, we estimate that onlysid_length and sid_bits_per_character session options should be exposed. These options à optional.

For others, we recommend changing your php.ini file

We can now configure the session like this :

framwork:session:sid_length:64 //optional, recommended value is 32sid_bits_per_character:6 //optional, recommended value is 5

@derrabus
Copy link
Member

In#29830,@pravdinalex reported that the 3.4 branch lacks support for those options as well. Was this PR intentionally opened against the master branch?

@OskarStark
Copy link
Contributor

As this is a new "feature" it must be againstmaster per definition, right?

@derrabus
Copy link
Member

As this is a new "feature"

Is it? The new feature has been implemented in php itself and the HTTP Foundation component already supports it. One could argue that this PR merely solves a configuration issue of the Framework Bundle.

I don't have a clear opinion on this. I've just noticed a contradiction between the linked issue and the PR and thought I should mention it. 😃

OskarStark reacted with thumbs up emoji

@XuruDragon
Copy link
Author

XuruDragon commentedJan 30, 2019•
edited
Loading

yes indeed, my first intention was to make it a bugfix for the 3.4 branch.

But as it can change the behavior of the application and can be set in the application, it sounds like a new feature. But I'm open to change it.

@XuruDragonXuruDragon changed the title[FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in session configuration[WIP] [FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in session configurationJan 30, 2019
@XuruDragonXuruDragon changed the title[WIP] [FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in session configuration[FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in session configurationJan 30, 2019
@nicolas-grekas
Copy link
Member

That's a new feature to me. Reports that ask for bug fixes but really ask for feature are not uncommon :)

derrabus, OskarStark, and XuruDragon reacted with thumbs up emoji

@XuruDragonXuruDragonforce-pushed theissue-29830 branch 2 times, most recently fromdd20abf to0ea374cCompareFebruary 7, 2019 12:02
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedFeb 8, 2019•
edited
Loading

rebase needed

…ni options in configuration| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |symfony#29830| License       | MIT| Doc PR        | n/athis a fix for the issuesymfony#29830After deliberation, we estimate that only `sid_length` and` sid_bits_per_character` session options should be exposed. These options à optional.For others, we recommend changing your php.ini fileWe can now configure the session like this :```yamlframwork:  session:    sid_length: 64 //optional, recommended value is 32    sid_bits_per_character: 6 //optional, recommended value is 5```
@XuruDragon
Copy link
Author

rebase needed

done

@nicolas-grekas
Copy link
Member

Thank you@XuruDragon.

@nicolas-grekasnicolas-grekas merged commit0403e4a intosymfony:masterFeb 8, 2019
nicolas-grekas added a commit that referenced this pull requestFeb 8, 2019
…acter session ini options in session configuration (XuruDragon)This PR was merged into the 4.3-dev branch.Discussion----------[FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in session configuration| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#29830| License       | MIT| Doc PR        | n/athis a fix for the issue#29830After deliberation, we estimate that only `sid_length` and` sid_bits_per_character` session options should be exposed. These options à optional.For others, we recommend changing your php.ini fileWe can now configure the session like this :```yamlframwork:  session:    sid_length: 64 //optional, recommended value is 32    sid_bits_per_character: 6 //optional, recommended value is 5```Commits-------0403e4a [FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in configuration
@XuruDragonXuruDragon deleted the issue-29830 branchFebruary 8, 2019 12:31
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestFeb 11, 2019
This PR was merged into the master branch.Discussion----------Update the documentation for the PR #30027Seesymfony/symfony#30027Added `sid_length` and `sid_vits_per_character` optionsCommits-------8e44f8e Update the documentation for the PR #30027
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark requested changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@derrabusderrabusderrabus approved these changes

+1 more reviewer

@linaorilinaorilinaori left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@XuruDragon@derrabus@OskarStark@nicolas-grekas@javiereguiluz@linaori@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp