Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarDumper] dont implement Serializable in Stub#30026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| publicfunction__sleep() | ||
| { | ||
| return\serialize([$this->class,$this->position,$this->cut,$this->type,$this->value,$this->handle,$this->refCount,$this->attr]); | ||
| $this->serialized = [$this->class,$this->position,$this->cut,$this->type,$this->value,$this->handle,$this->refCount,$this->attr]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't we add the property declaration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nope, that's the trick: this is a purely transient state. Declaring a property would mean extra memory used for each instance for zero benefits.
…rekas)This PR was merged into the 3.4 branch.Discussion----------[VarDumper] dont implement Serializable in Stub| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#30014| License | MIT| Doc PR | -`Serializable` is really really broken...Commits-------73070d7 [VarDumper] dont implement Serializable in Stub
Serializableis really really broken...