Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] add id of referencing service when a deprecated alias is found#29995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
javiereguiluz commentedJan 28, 2019
Nice improvement! Not sure if it's possible, but I'd reword the error message: like this: |
MemberAuthor
nicolas-grekas commentedJan 28, 2019
I'd happily improve the message, but your suggestion is not possible, see L65 how the message is constructed. We can only append or prepend to the message conveyed by the alias. |
javiereguiluz approved these changesJan 28, 2019
Member
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
Member
stof commentedJan 28, 2019
Note that this PR is renaming the placeholder used in the message. When it gets merged, the blog post published today should be updated to reflect the change. |
stof approved these changesJan 28, 2019
nicolas-grekas added a commit that referenced this pull requestJan 28, 2019
… is found (nicolas-grekas)This PR was merged into the 4.3-dev branch.Discussion----------[DI] add id of referencing service when a deprecated alias is found| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Improves#29968 a bit for DX.Commits-------b124fb7 [DI] add id of referencing service when a deprecated alias is found
Member
stof commentedJan 28, 2019
@nicolas-grekas with your change to move the trigger_error outside the loop, what happens if you have |
MemberAuthor
nicolas-grekas commentedJan 28, 2019
yes, because of the loop in process (see L32) |
Member
javiereguiluz commentedJan 29, 2019
@stof thanks for this warning. The blog post has been updated accordingly. |
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestJan 29, 2019
…iluz)This PR was squashed before being merged into the master branch (closes#10937).Discussion----------Documented the deprecation of service aliasesIt documentssymfony/symfony#29968 but it contains the changes of the pending PRsymfony/symfony#29995Commits-------d5d87e6 Documented the deprecation of service aliases
XuruDragon pushed a commit to XuruDragon/symfony that referenced this pull requestFeb 4, 2019
…ebug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aFix and improves a bit PRsymfony#29968 andsymfony#29995
XuruDragon pushed a commit to XuruDragon/symfony that referenced this pull requestFeb 4, 2019
…ebug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aFix and improves a bit PRsymfony#29968 andsymfony#29995
XuruDragon pushed a commit to XuruDragon/symfony that referenced this pull requestFeb 4, 2019
…ebug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aFix and improves a bit PRsymfony#29968 andsymfony#29995
XuruDragon pushed a commit to XuruDragon/symfony that referenced this pull requestFeb 4, 2019
…ebug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aFix and improves a bit PRsymfony#29968 andsymfony#29995
XuruDragon pushed a commit to XuruDragon/symfony that referenced this pull requestFeb 5, 2019
…ebug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aFix and improves a bit PRsymfony#29968 andsymfony#29995
XuruDragon pushed a commit to XuruDragon/symfony that referenced this pull requestFeb 6, 2019
…ebug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aFix and improves a bit PRsymfony#29968 andsymfony#29995
XuruDragon pushed a commit to XuruDragon/symfony that referenced this pull requestFeb 6, 2019
…ebug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aFix and improves a bit PRsymfony#29968 andsymfony#29995
XuruDragon pushed a commit to XuruDragon/symfony that referenced this pull requestFeb 6, 2019
…ebug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aFix and improves a bit PRsymfony#29968 andsymfony#29995
XuruDragon pushed a commit to XuruDragon/symfony that referenced this pull requestFeb 6, 2019
…ebug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aFix and improves a bit PRsymfony#29968 andsymfony#29995
XuruDragon pushed a commit to XuruDragon/symfony that referenced this pull requestFeb 7, 2019
…ebug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aFix and improves a bit PRsymfony#29968 andsymfony#29995
nicolas-grekas added a commit that referenced this pull requestFeb 8, 2019
…ed aliases in debug:autowiring (XuruDragon)This PR was merged into the 4.3-dev branch.Discussion----------[DependencyInjection] Added information about deprecated aliases in debug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | n/aFix and improves a bit PR#29968 and#29995Commits-------3d2378d [DependencyInjection] Added information about deprecated aliases in debug:autowiring
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
DependencyInjectionDXDX = Developer eXperience (anything that improves the experience of using Symfony) Status: Reviewed
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves#29968 a bit for DX.