Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] Fixed search bar#29984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.2fromro0NL:dumper
Jan 27, 2019
Merged

[VarDumper] Fixed search bar#29984

nicolas-grekas merged 1 commit intosymfony:4.2fromro0NL:dumper
Jan 27, 2019

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedJan 25, 2019•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

Continuation of#28854, replaces#29176

initial:

image

ctrl f:

image

scroll:

image

tested in chrome+ff

cc@ogizanagi

refhttps://caniuse.com/#feat=css-sticky

linaori and yceruto reacted with thumbs up emoji
@ro0NL
Copy link
ContributorAuthor

made sure the first result wont be hidden under the search bar:

image

i think this nails it :)

ostrolucky, fancyweb, and yceruto reacted with thumbs up emoji

Copy link
Contributor

@ogizanagiogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for working on this ❤️

@fabpot
Copy link
Member

Shouldn't we merge this one on an older branch?

@ro0NLro0NL changed the base branch frommaster to4.2January 25, 2019 17:59
@Koc
Copy link
Contributor

Koc commentedJan 26, 2019•
edited
Loading

Is it possible to disable this search bar in general?

@ro0NL
Copy link
ContributorAuthor

@Koc see#29748, IMHO it's developer preference so im not sure how to deal with it. Different topic though :)

@nicolas-grekasnicolas-grekas added this to the4.2 milestoneJan 27, 2019
@nicolas-grekas
Copy link
Member

Thank you@ro0NL.

@nicolas-grekasnicolas-grekas merged commit99d2893 intosymfony:4.2Jan 27, 2019
nicolas-grekas added a commit that referenced this pull requestJan 27, 2019
This PR was squashed before being merged into the 4.2 branch (closes#29984).Discussion----------[VarDumper] Fixed search bar| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Continuation of#28854, replaces#29176initial:![image](https://user-images.githubusercontent.com/1047696/51747953-3c9e1400-20ab-11e9-913d-d60bd59ee2d9.png)ctrl f:![image](https://user-images.githubusercontent.com/1047696/51747973-4b84c680-20ab-11e9-8d07-e6128822fbb2.png)scroll:![image](https://user-images.githubusercontent.com/1047696/51747984-550e2e80-20ab-11e9-8b54-b24109d2280a.png)tested in chrome+ffcc@ogizanagirefhttps://caniuse.com/#feat=css-stickyCommits-------99d2893 [VarDumper] Fixed search bar
@ro0NLro0NL deleted the dumper branchJanuary 27, 2019 15:39
@fabpotfabpot mentioned this pull requestFeb 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@ro0NL@fabpot@Koc@nicolas-grekas@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp